chore: tidy up

Author: iziang

aperag/index/manager.py

@@ -120,6 +120,9 @@ async def rebuild_document_indexes(
             document_id: Document ID
             index_types: List of index types to rebuild
         """
+        if len(set(index_types)) != len(index_types):
+            raise Exception("Duplicate index types are not allowed")
+
         for index_type in index_types:
             stmt = select(DocumentIndex).where(
                 and_(DocumentIndex.document_id == document_id, DocumentIndex.index_type == index_type)

aperag/service/document_service.py

@@ -417,6 +417,9 @@ async def rebuild_document_indexes(
         Returns:
             dict: Success response
         """
+        if len(set(index_types)) != len(index_types):
+            raise invalid_param("index_types", "duplicate index types are not allowed")
+
         logger.info(f"Rebuilding indexes for document {document_id} with types: {index_types}")
 
         # Convert index types to enum values outside transaction

tests/e2e_test/test_document.py

@@ -129,3 +129,114 @@ def test_upload_duplicate_then_delete_and_reupload(client, collection):
     assert "items" in data3
     assert len(data3["items"]) == 1
     assert data3["items"][0]["name"] == filename
+
+
+# Document index rebuild tests
+def test_rebuild_single_index_type(client, document, collection):
+    """Test rebuilding a single index type (vector)"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    # Test rebuilding vector index
+    rebuild_request = {"index_types": ["vector"]}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    assert response.status_code == HTTPStatus.OK, response.text
+    data = response.json()
+    assert data["code"] == "200"
+    assert "vector" in data["message"]
+
+
+def test_rebuild_all_index_types(client, document, collection):
+    """Test rebuilding all supported index types"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    # Test rebuilding all index types
+    rebuild_request = {"index_types": ["vector", "fulltext", "graph"]}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    assert response.status_code == HTTPStatus.OK, response.text
+    data = response.json()
+    assert data["code"] == "200"
+    assert "vector" in data["message"]
+    assert "fulltext" in data["message"]
+    assert "graph" in data["message"]
+
+
+def test_rebuild_index_invalid_index_type(client, document, collection):
+    """Test rebuilding with invalid index type"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    # Test with invalid index type
+    rebuild_request = {"index_types": ["invalid_type"]}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    assert response.status_code == HTTPStatus.BAD_REQUEST, response.text
+
+
+def test_rebuild_index_empty_index_types(client, document, collection):
+    """Test rebuilding with empty index types array"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    # Test with empty index types
+    rebuild_request = {"index_types": []}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    assert response.status_code == HTTPStatus.UNPROCESSABLE_ENTITY, response.text
+
+
+@pytest.mark.parametrize("index_type", ["vector", "fulltext", "graph"])
+def test_rebuild_individual_index_types(client, document, collection, index_type):
+    """Test rebuilding each individual index type"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    rebuild_request = {"index_types": [index_type]}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    assert response.status_code == HTTPStatus.OK, response.text
+    data = response.json()
+    assert data["code"] == "200"
+    assert index_type in data["message"]
+
+
+def test_rebuild_index_duplicate_types(client, document, collection):
+    """Test rebuilding with duplicate index types in request"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    # Test with duplicate index types
+    rebuild_request = {"index_types": ["vector", "vector", "fulltext"]}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    # Should fail
+    assert response.status_code == HTTPStatus.BAD_REQUEST, response.text
+
+
+def test_rebuild_index_case_sensitivity(client, document, collection):
+    """Test rebuilding with different case index types"""
+    doc_id = document["id"]
+    collection_id = collection["id"]
+    
+    # Test with uppercase index type (should fail)
+    rebuild_request = {"index_types": ["VECTOR"]}
+    response = client.post(
+        f"/api/v1/collections/{collection_id}/documents/{doc_id}/rebuild_indexes",
+        json=rebuild_request
+    )
+    assert response.status_code == HTTPStatus.UNPROCESSABLE_ENTITY, response.text