Commit c4dd86b
authored
ci(e2e-http): split into 2 PR-triggered workflows (lite + full) sharing reusable shape workflow (PR-2 of 2) (#1744)
* ci(e2e-http): split into 2 PR-triggered workflows (lite + full) sharing reusable shape workflow
Follow-up to #1740 / #1743. Replaces #1740's intra-job matrix on
``e2e-http-smoke`` with two separate top-level workflows, each
PR-triggered and each pinned to one deployment shape. The matrix in
#1740 ran identical lanes through the smoke layer; the only difference
between lanes was which lazy-init backend the api picked, and the smoke
hurl files all set ``enable_*: false`` so neither lane actually
exercised pgvector / PG-graph / qdrant / neo4j data paths.
This PR moves the shape variation up one layer so each PR runs *both*
the smoke layer *and* the provider-aware layer under each shape — the
provider layer is where real ingest (embedding + KG extraction) and
recall happen, so under this structure the lite job actually exercises
the pgvector + PG-graph data path and the full job actually exercises
qdrant + neo4j. LLM token cost per PR doubles; this was confirmed
acceptable.
Files:
- ``e2e-http-shape.yml`` (NEW, reusable) — takes ``shape`` input, runs
smoke + provider-preflight + provider-aware suite for that shape.
``SHAPE`` env var threads through to ``up.sh``, which sources the
matching ``tests/e2e_http/shapes/<shape>.env`` (introduced in #1743).
Artifact upload names include the shape so multi-shape runs do not
clash.
- ``e2e-http-lite.yml`` (NEW, top-level) — PR-triggered + manual; calls
``e2e-http-shape.yml`` with ``shape: lite`` (pgvector + PG-graph).
- ``e2e-http-full.yml`` (NEW, top-level) — PR-triggered + manual; calls
``e2e-http-shape.yml`` with ``shape: full-neo4j`` (Qdrant + Neo4j).
- ``e2e-http-smoke.yml`` (DELETED) — superseded.
- ``cicd-pull-request.yml`` (DELETED) — superseded; the lite/full
workflows now PR-trigger directly.
Adding a new shape (e.g. nebula) is one new ``e2e-http-<name>.yml``
caller file plus the matching ``shapes/<name>.env`` from #1743.
Doc references to the deleted workflow file names (e.g.
``docs/modularization/hurl-coverage-matrix.md``) are deferred to a
follow-up sweep — the ``e2e-http-smoke`` *job* name still exists inside
``e2e-http-shape.yml``, so most of those references remain
semantically correct.
* ci/test: rename shapes to <vector>-<graph>; add qdrant-nebula workflow
"full" was misleading because Qdrant+Neo4j and Qdrant+Nebula are equally
"full" deployments. Switch to ``<vector>-<graph>`` naming with ``lite``
kept as the special name for the single-PG (pgvector + PG-graph)
ApeRAG-Lite deployment:
- ``full-neo4j`` → ``qdrant-neo4j``
- ``full-nebula`` → ``qdrant-nebula``
- ``lite`` unchanged
The new naming scales: a future hybrid like ``pgvector-neo4j`` slots
in cleanly without needing a "full / fuller / fullest" hierarchy.
Also wires Nebula into PR-triggered CI per request — every PR now runs
all three shapes through both the smoke and the provider-aware layer.
LLM token cost per PR triples; this is acceptable for now and a fake
provider is on the roadmap to drop the cost back down.
Files:
- ``tests/e2e_http/shapes/qdrant-{neo4j,nebula}.env`` (renamed; header
comments updated)
- ``.github/workflows/e2e-http-qdrant-neo4j.yml`` (renamed from
``e2e-http-full.yml``; display name "E2E HTTP Qdrant + Neo4j";
``shape: qdrant-neo4j``)
- ``.github/workflows/e2e-http-qdrant-nebula.yml`` (NEW; display name
"E2E HTTP Qdrant + Nebula"; ``shape: qdrant-nebula``)
- ``Makefile`` shortcuts: ``test-http-smoke-compose-qdrant-neo4j``
/ ``-qdrant-nebula`` (old ``-full`` target dropped — only existed
in #1743 / origin/main, not yet referenced anywhere external)
- ``tests/e2e_http/runners/compose/README.md`` reflects new names
* test(unit): update e2e-http workflow contract test for new shape structure1 parent 52444d4 commit c4dd86b
11 files changed
Lines changed: 127 additions & 64 deletions
File tree
- .github/workflows
- tests
- e2e_http
- runners/compose
- shapes
- unit_test
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
Lines changed: 24 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
2 | 7 | | |
3 | 8 | | |
4 | 9 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
10 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
11 | 22 | | |
12 | 23 | | |
13 | 24 | | |
14 | 25 | | |
15 | 26 | | |
16 | 27 | | |
17 | 28 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | 29 | | |
34 | | - | |
35 | | - | |
| 30 | + | |
36 | 31 | | |
37 | 32 | | |
38 | 33 | | |
| |||
71 | 66 | | |
72 | 67 | | |
73 | 68 | | |
74 | | - | |
| 69 | + | |
75 | 70 | | |
76 | 71 | | |
77 | 72 | | |
| |||
122 | 117 | | |
123 | 118 | | |
124 | 119 | | |
| 120 | + | |
125 | 121 | | |
126 | 122 | | |
127 | 123 | | |
| |||
162 | 158 | | |
163 | 159 | | |
164 | 160 | | |
165 | | - | |
| 161 | + | |
166 | 162 | | |
167 | 163 | | |
168 | 164 | | |
| |||
176 | 172 | | |
177 | 173 | | |
178 | 174 | | |
179 | | - | |
| 175 | + | |
180 | 176 | | |
181 | 177 | | |
182 | 178 | | |
| |||
187 | 183 | | |
188 | 184 | | |
189 | 185 | | |
190 | | - | |
191 | | - | |
| 186 | + | |
| 187 | + | |
192 | 188 | | |
193 | 189 | | |
194 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | | - | |
| 208 | + | |
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
| |||
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
289 | | - | |
290 | | - | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
291 | 294 | | |
292 | 295 | | |
293 | 296 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
41 | | - | |
42 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
0 commit comments