feat: refine node merge

[earayu]

No description provided.

[cursor]

Bug: Merge Suggestion Expiry Regression

The handle_suggestion_action method, when accepting a merge suggestion, omits the call to self.db_ops.expire_related_suggestions. This regression from the previous implementation allows related merge suggestions involving the same entities to remain active instead of being marked as EXPIRED. This leads to data inconsistency and conflicting suggestions, contrary to API documentation and unit test expectations.

aperag/service/graph_service.py#L329-L351

ApeRAG/aperag/service/graph_service.py

Lines 329 to 351 in 1874d39

	else: # normalized_action == "accept"
	# Accept and perform merge
	merge_target_data = target_entity_data or suggestion.suggested_target_entity
	# Execute merge operation
	merge_result = await self._execute_merge_operation(
	db_collection=db_collection,
	entity_ids=suggestion.entity_ids,
	target_entity_data=merge_target_data,
	)
	# Update suggestion status to ACCEPTED
	await self.db_ops.update_suggestion_status(suggestion_id, MergeSuggestionStatus.ACCEPTED, utc_now())
	logger.info(f"Suggestion {suggestion_id} has been accepted and merge completed")
	return {
	"status": "success",
	"message": f"Suggestion {suggestion_id} has been accepted and merge completed",
	"suggestion_id": suggestion_id,
	"action": normalized_action,
	"merge_result": merge_result,
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎