Skip to content

Phase 8: hard-cut identity auth routes#1671

Merged
earayu merged 1 commit into
mainfrom
dongdong/phase8-identity-auth-hardcut
Apr 25, 2026
Merged

Phase 8: hard-cut identity auth routes#1671
earayu merged 1 commit into
mainfrom
dongdong/phase8-identity-auth-hardcut

Conversation

@earayu
Copy link
Copy Markdown
Collaborator

@earayu earayu commented Apr 25, 2026

Summary

Phase 8 task #36: identity/auth route dependency hard-cut.

  • Move legacy aperag/views/auth.py into aperag/domains/identity/api/auth_routes.py and delete aperag/auth/*.
  • Move auth dependency wiring into aperag/domains/identity/service/auth_dependencies.py and login-method config helpers into aperag/domains/identity/service/login_methods.py.
  • Mount identity auth at /api/v2/auth and config at /api/v2/config; remove the old /api/v1 auth/config route exposure.
  • Update domain route imports, remaining legacy v1 routes that still consume auth dependencies, FE typed adapters, hurl/e2e scripts, and schema path keys for the auth/config hard-cut.
  • Add a modularization boundary test banning domain imports from aperag.views.auth.

Boundary Notes

Verification

  • uv run pytest tests/unit_test/test_modularization_boundaries.py tests/unit_test/test_openapi_spec.py -q -> 24 passed
  • uv run pytest tests/unit_test/test_web_typed_api_contract.py::test_final_sweep_v1_ghost_paths_are_gone_from_exported_spec tests/unit_test/test_web_typed_api_contract.py::test_e2e_http_does_not_call_removed_v1_paths tests/unit_test/test_web_typed_api_contract.py::test_phase1_fe_complete_identity_auth_admin_audit_adapter_boundary -q -> 3 passed
  • uv run python scripts/export_openapi.py --check -> pass
  • uv run ruff check aperag tests/unit_test/test_modularization_boundaries.py tests/unit_test/test_openapi_spec.py tests/unit_test/test_web_typed_api_contract.py tests/e2e_pytest/conftest.py -> pass
  • cd web && yarn lint -> pass
  • git diff --check origin/main...HEAD -> pass
  • route smoke via aperag.app: /api/v2/auth/{login,register,user,users,invite,invitations,change-password} and /api/v2/config present; old /api/v1/{login,register,user,users,invite,config} absent

cd web && yarn tsc --noEmit still fails on known mainline FE type issues in page.tsx, collection-form.tsx, chat-input.tsx, and collection-provider.tsx; none are introduced by this PR.

@earayu earayu force-pushed the dongdong/phase8-identity-auth-hardcut branch from 5531ce9 to acd9359 Compare April 25, 2026 04:34
@earayu earayu merged commit c7dc57d into main Apr 25, 2026
0 of 2 checks passed
@earayu earayu deleted the dongdong/phase8-identity-auth-hardcut branch April 25, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant