refactor(concurrent-control): make locks redis-first#1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Task #38: concurrent_control Redis-first hardening.
APERAG_LOCK_TYPE, defaulting toredisinstead ofthreading.create_distributed_lock(...)API for Redis-backed production locks.threadinglocks as explicit opt-in for single-process/test/local usage._lock_valuerace.aperag/service/evaluation_service.pyin cleanup(phase8/task39): legacy ORM carve + old evaluation stack hard-delete + partial unique indexes #1670/[Features] support chinese model baichuan-13b #39, so there is no remaining legacy eval bridge to update in this PR.Gates
uv run --extra test python -m pytest tests/unit_test/concurrent_control tests/unit_test/test_modularization_boundaries.py -q-> 110 passed, 3 warningsuv run ruff format --check aperag/concurrent_control tests/unit_test/concurrent_control-> passuv run ruff check aperag/concurrent_control tests/unit_test/concurrent_control-> passgit diff --check-> passrg "get_or_create_lock\\(" aperag -g '*.py' -g '!aperag/concurrent_control/manager.py'-> no production callersrg "lock_type=\\\"threading\\\"|\\\"threading\\\"\\)" aperag -g '*.py' -g '!aperag/concurrent_control/manager.py'-> no production callersrg "evaluation_service|from aperag\\.concurrent_control\\.redis_lock import RedisLock|RedisLock\\(" aperag -g '*.py'-> only concurrent_control internals