docs(indexing): §G.5 amendment — index_modality field (not modality)#1728
Merged
Conversation
…trieval-modality discriminator Bryce T3.2 implementation (PR #1727 follow-up commit 5325788 on chenyexuan/celery-wave3-cutover) flagged a name collision: D10.h already locked SearchResultMetadata.modality as the content-modality field (Literal["text", "image"]). v3 design pack §G.5 narrative re-used `modality` for "which retrieval modality served this hit" (Literal["vector", "fulltext", "graph", "summary", "vision"]), which would shadow the D10.h field. Architect ack of Bryce's chosen disambiguation: rename the new field to `index_modality`. D10.h `modality` (content) preserved. SearchResultMetadata gains three new fields total: parse_version / index_modality / index_state_per_modality. The two are orthogonal — a hit can be (index_modality="vector", modality="text") or (index_modality="vision", modality="image"). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architect amendment to design pack §G.5 disambiguating field name for retrieval-modality discriminator.
Bryce T3.2 implementation (Wave 3 PR #1727 commit
53257881, msg=1a02cbcb) caught: design pack §G.5 narrative used baremodalityfield onSearchResultMetadata, but D10.h already lockedSearchResultMetadata.modalityas the content modality (Literal["text", "image"]). The narrative naming would shadow the D10.h field.Bryce chose
index_modalityfor disambiguation. Architect ack: this is the canonical name; spec amended to match.Changes
modality→index_modalityfor retrieval-modality discriminatorTest plan
index_modality(PR feat(celery Wave 2): runtime + cutover/quota + load test #1727 commit 5325788)modalityfield preserved for content modality🤖 Generated with Claude Code