test(compat): cover list_entity_labels() — close Wave 6 #40 follow-up#1750
Merged
Conversation
PR #1748 (LineageGraphStore matrix) intentionally deferred coverage of ``list_entity_labels()`` because that method landed concurrently with PR #1746 (Wave 6 #40 narrow replacement). Now that #1746 is merged, this PR closes the deferred slot — same pattern as the other 12 methods, parametrized over postgresql / neo4j / nebula backends. Three tests: - ``test_list_entity_labels_returns_distinct_sorted`` — locks the Wave 6 #40 contract (sorted distinct ``EntityRecord.entity_type`` values; collection-scoped per-instance store, no ``collection_id`` parameter at this layer). - ``test_list_entity_labels_empty_collection_returns_empty`` — pins the docstring invariant (line 594-596): empty collection returns ``[]``, not a fall-back to legacy graphindex. - ``test_list_entity_labels_excludes_orphan_after_gc`` — exercises the read path against a real backend GC interaction. The InMemory reference impl can't catch SQL/Cypher/nGQL-specific DISTINCT-after-DELETE issues; this test does. Closes the last open item under #测试 task #25 ("coverage audit").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #1748 (LineageGraphStore matrix), which intentionally deferred coverage of
list_entity_labels()because that method landed concurrently in PR #1746 (Wave 6 #40 narrow replacement). With #1746 merged, this PR closes the deferred slot.What's added
Three tests in
tests/integration/compat/test_lineage_graph_compat.py, parametrized over postgresql / neo4j / nebula backends:test_list_entity_labels_returns_distinct_sorted— locks the Wave 6 [Features] support english model openchat #40 contract: sorted distinctEntityRecord.entity_typevalues; collection-scoped per-instance store, nocollection_idparameter at this layer.test_list_entity_labels_empty_collection_returns_empty— pins the Protocol docstring invariant (lines 594-596): empty collection returns[](not a fall-back to legacy graphindex).test_list_entity_labels_excludes_orphan_after_gc— exercises the read path against a real backend GC interaction. The InMemory reference impl can't catch SQL/Cypher/nGQL-specific DISTINCT-after-DELETE issues; this test does.Coverage matrix (post-merge)
All 12 methods of
LineageGraphStoreProtocol now have parametrized matrix coverage intest_lineage_graph_compat.py× 3 production backends (Postgres / Neo4j / Nebula).Test plan
Context
Closes the last open item under #测试 task #25 ("DB compatibility coverage audit"). Subsequent follow-ups (Gap-D — re-enable
run_graph_index_flow.sh) tracked under #indexing task #42, parked until Wave 7+ legacy graphindex package deletion ships.🤖 Generated with Claude Code