Skip to content

fix: concurrent index reconciling#958

Merged
iziang merged 6 commits into
mainfrom
bugfix/concurrent-reconciling
Jun 19, 2025
Merged

fix: concurrent index reconciling#958
iziang merged 6 commits into
mainfrom
bugfix/concurrent-reconciling

Conversation

@iziang

@iziang iziang commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@apecloud-bot apecloud-bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 19, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@cursor

cursor Bot commented Jun 19, 2025

Copy link
Copy Markdown

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_e7ca7cc6-2ace-467b-9bd5-b5ba792cc016).

@iziang

iziang commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor

cursor Bot commented Jun 19, 2025

Copy link
Copy Markdown

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_7cdfc488-2f54-414d-a90e-fc9cd076ede0).

@iziang

iziang commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Debug Code Causes Excessive Logging

The traceback.print_stack() call in the BusinessException constructor, which appears to be debugging code, prints a stack trace to stdout/stderr every time any business exception is created. This includes expected exceptions (e.g., "resource not found"), leading to excessive log noise and potential performance impact in production.

aperag/exceptions.py#L92-L93

self.details = details or {}
traceback.print_stack()

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

@iziang iziang merged commit b05f910 into main Jun 19, 2025
6 of 7 checks passed
@iziang iziang deleted the bugfix/concurrent-reconciling branch June 19, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants