Skip to content

feat: update session cookie management and JWT expiration #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iziang merged 1 commit into from
Jun 26, 2025
Merged

feat: update session cookie management and JWT expiration #996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions aperag/views/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

# --- fastapi-users Implementation ---

COOKIE_MAX_AGE = 86400


class UserManager(BaseUserManager[User, str]):
reset_password_token_secret = "SECRET"
Expand All @@ -53,11 +55,11 @@ def parse_id(self, value: any) -> str:


def get_jwt_strategy() -> JWTStrategy:
return JWTStrategy(secret=SECRET, lifetime_seconds=3600)
return JWTStrategy(secret=SECRET, lifetime_seconds=86400)


# Transport methods
cookie_transport = CookieTransport(cookie_name="session", cookie_max_age=3600)
cookie_transport = CookieTransport(cookie_name="session", cookie_max_age=COOKIE_MAX_AGE)

# Authentication backends
cookie_backend = AuthenticationBackend(
Expand Down Expand Up @@ -394,7 +396,7 @@ async def login_view(
token = await strategy.write_token(user)

# Set cookie
response.set_cookie(key="session", value=token, max_age=3600, httponly=True, samesite="lax")
response.set_cookie(key="session", value=token, max_age=COOKIE_MAX_AGE, httponly=True, samesite="lax")

return view_models.User(
id=str(user.id),
Expand Down
Loading