Skip to content

Hide apps and rename recipes to workflows#13

Merged
earayu merged 3 commits into
mainfrom
codex/hide-apps-feature
May 24, 2026
Merged

Hide apps and rename recipes to workflows#13
earayu merged 3 commits into
mainfrom
codex/hide-apps-feature

Conversation

@earayu
Copy link
Copy Markdown
Collaborator

@earayu earayu commented May 24, 2026

What\n- Hide the Apps entry from navigation defaults and the navigation customization UI.\n- Redirect direct /apps visits back to the home view instead of rendering the Apps page.\n- Rename user-facing Recipe/Recipes copy to Workflow/Workflows, including Chinese translations from 配方 to 工作流.\n\n## Why\nApeMind Agent should keep the underlying Goose recipe protocol for upstream compatibility, while presenting the feature to users as workflows. The Apps feature should be hidden at the UI entry level without deleting the MCP App/resource implementation.\n\n## Validation\n- pnpm -C ui/desktop run i18n:check\n- pnpm -C ui/desktop exec eslint --max-warnings 0 --no-warn-ignored\n- git diff --check\n\n## Known issue\n- pnpm -C ui/desktop run typecheck currently fails before reaching changed files because announcements/content and announcements/index.json are missing in this checkout.\n

@earayu
Copy link
Copy Markdown
Collaborator Author

earayu commented May 24, 2026

@梅西 CR LGTM from @冯诺伊曼。

Review focus:

  • Apps 只做前端入口隐藏和 /apps 重定向,底层 MCP Apps / standalone app 代码保留,符合后续追上游的最小 diff 原则。
  • 用户可见 Recipe/Recipes 文案改为 Workflow/Workflows,但 goose://recipe 协议、recipe 数据模型和代码命名保留,兼容上游。

Local verification:

  • 独立 worktree 安装依赖后,Node v24.12.0 + pnpm 10.30.0。
  • pnpm -C ui/desktop run lint:check 通过。

说明:当前 GitHub token 被识别为 PR author,不能提交 formal approve,所以用 comment 记录 CR 结论。

@earayu
Copy link
Copy Markdown
Collaborator Author

earayu commented May 24, 2026

CR follow-up:CI 的 Test and Lint Electron Desktop App 失败不是产品代码问题,是这次把 Recipe 用户文案改为 Workflow 后,两个前端测试仍在按旧文案断言。

我已直接补一小个测试修复 commit:626b7cb Fix workflow rename desktop tests

本地验证已过:

  • pnpm -C ui/desktop run lint:check
  • pnpm -C ui/desktop run test:run ✅(26 files / 347 tests)

@earayu
Copy link
Copy Markdown
Collaborator Author

earayu commented May 24, 2026

补充了 earayu2 截图里的两个隐藏点:

  • Settings → Models 顶部不再显示 Local Inference / Mesh 两个 Tab。
  • settings?section=local-inference / settings?section=mesh 不再映射到隐藏页,避免深链路打开。
  • 不删除底层 local inference / mesh 代码,只做 UI 层隐藏,保持上游合并友好。
  • 新增 SettingsView 测试 pin:这两个 Tab 不渲染,深链路仍回到 Models。

验证:

  • pnpm -C ui/desktop run lint:check
  • pnpm -C ui/desktop run test:run ✅(27 files / 348 tests)

提交:279966d

@earayu earayu merged commit 1868577 into main May 24, 2026
21 checks passed
@earayu earayu deleted the codex/hide-apps-feature branch May 24, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant