fix(desktop): keep workflow cancel in current window#27
Merged
Conversation
earayu
added a commit
that referenced
this pull request
May 28, 2026
Take origin/main version (PR #27 navigate('/pair')) over upstream HEAD (onClose()). navigate('/pair') routes to a fresh blank /pair session, which matches the user intent better than onClose() (which would continue the recipe-pair without params). Signed-off-by: earayu <earayu@163.com>
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a user cancels a workflow parameter form and chooses "Start New Chat", the desktop app currently creates a new chat window and hides the current window. That feels surprising because the user expects to continue in the same app surface.
What changed
createChatWindow + hideWindowinParameterInputModalwith an in-placenavigate('/pair').Verification
pnpm -C ui/desktop exec eslint src/components/ParameterInputModal.tsx --max-warnings 0 --no-warn-ignoredgit diff --check