fix: resolve govet printf non-constant format string in spinnerMsg calls

Replace runtime string concatenation with format placeholders in
spinnerMsg calls to satisfy govet's printf analyzer.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: shanshanying

pkg/cmd/kubeblocks/config.go

@@ -107,7 +107,7 @@ func configKBRelease(o *InstallOptions) error {
 	if kbRelease != nil && kbRelease.Chart != nil && kbRelease.Chart.Metadata != nil {
 		kbVersion = kbRelease.Chart.Metadata.Version
 	}
-	s := spinner.New(o.Out, spinnerMsg("Config KubeBlocks "+kbVersion))
+	s := spinner.New(o.Out, spinnerMsg("Config KubeBlocks %s", kbVersion))
 	defer s.Fail()
 	o.disableHelmPreHookJob()
 	// upgrade KubeBlocks chart

pkg/cmd/kubeblocks/install.go

@@ -299,7 +299,7 @@ func (o *InstallOptions) Install() error {
 	s.Success()
 
 	// add helm repo
-	s = spinner.New(o.Out, spinnerMsg("Add and update repo "+types.KubeBlocksRepoName))
+	s = spinner.New(o.Out, spinnerMsg("Add and update repo %s", types.KubeBlocksRepoName))
 	defer s.Fail()
 	// Add repo, if exists, will update it
 	if err = helm.AddRepo(newHelmRepoEntry()); err != nil {
@@ -308,7 +308,7 @@ func (o *InstallOptions) Install() error {
 	s.Success()
 
 	// install KubeBlocks
-	s = spinner.New(o.Out, spinnerMsg("Install KubeBlocks "+o.Version))
+	s = spinner.New(o.Out, spinnerMsg("Install KubeBlocks %s", o.Version))
 	defer s.Fail()
 
 	getImageRegistry := func() string {
@@ -460,7 +460,7 @@ func (o *InstallOptions) waitAddonsEnabled() error {
 	msg := ""
 	header := "Wait for addons to be enabled"
 	failedErr := errors.New("some addons are failed to be enabled")
-	s := spinner.New(o.Out, spinnerMsg(header))
+	s := spinner.New(o.Out, spinnerMsg("Wait for addons to be enabled"))
 
 	var (
 		spinnerDone = func() {

pkg/cmd/kubeblocks/install_1.0.go

@@ -85,7 +85,7 @@ func (o *InstallOptions) preInstallWhenUpgradeFrom09() error {
 			deploy := &kbDeploys[i]
 			kbVersion := deploy.Labels[constant.AppVersionLabelKey]
 			o.kb09Namespace = deploy.Namespace
-			s := spinner.New(o.Out, spinnerMsg(fmt.Sprintf("Stop %s %s", msgKey, kbVersion)))
+			s := spinner.New(o.Out, spinnerMsg("Stop %s %s", msgKey, kbVersion))
 			if err = o.stopDeploymentObject(s, deploy); err != nil {
 				return err
 			}

pkg/cmd/kubeblocks/upgrade.go

@@ -178,7 +178,7 @@ func (o *InstallOptions) Upgrade() error {
 	}
 
 	// add helm repo
-	s := spinner.New(o.Out, spinnerMsg("Add and update repo "+types.KubeBlocksChartName))
+	s := spinner.New(o.Out, spinnerMsg("Add and update repo %s", types.KubeBlocksChartName))
 	defer s.Fail()
 	// Add repo, if exists, will update it
 	if err = helm.AddRepo(newHelmRepoEntry()); err != nil {
@@ -200,7 +200,7 @@ func (o *InstallOptions) Upgrade() error {
 		// stop the old version KubeBlocks, otherwise the old version KubeBlocks will reconcile the
 		// new version resources, which may be not compatible. helm will start the new version
 		// KubeBlocks after upgrade.
-		s = spinner.New(o.Out, spinnerMsg("Stop KubeBlocks "+kbVersion))
+		s = spinner.New(o.Out, spinnerMsg("Stop KubeBlocks %s", kbVersion))
 		if err = o.stopDeployment(s, util.GetKubeBlocksDeploy); err != nil {
 			return err
 		}
@@ -244,7 +244,7 @@ func (o *InstallOptions) Upgrade() error {
 		s.Success()
 	}
 
-	s = spinner.New(o.Out, spinnerMsg("Upgrading KubeBlocks "+msg))
+	s = spinner.New(o.Out, spinnerMsg("Upgrading KubeBlocks %s", msg))
 	defer s.Fail()
 	o.disableHelmPreHookJob()
 	// upgrade KubeBlocks chart

pkg/cmd/playground/destroy.go

@@ -104,7 +104,7 @@ func (o *destroyOptions) destroy() error {
 // destroyLocal destroy local k3d cluster that will destroy all resources
 func (o *destroyOptions) destroyLocal() error {
 	provider, _ := cp.New(cp.Local, "", o.Out, o.ErrOut)
-	s := spinner.New(o.Out, spinnerMsg("Delete playground k3d cluster "+o.prevCluster.ClusterName))
+	s := spinner.New(o.Out, spinnerMsg("Delete playground k3d cluster %s", o.prevCluster.ClusterName))
 	defer s.Fail()
 	if err := provider.DeleteK8sCluster(o.prevCluster); err != nil {
 		if !strings.Contains(err.Error(), "no cluster found") &&
@@ -358,7 +358,7 @@ func (o *destroyOptions) uninstallKubeBlocks(client kubernetes.Interface, dynami
 }
 
 func (o *destroyOptions) removeKubeConfig() error {
-	s := spinner.New(o.Out, spinnerMsg("Remove kubeconfig from "+defaultKubeConfigPath))
+	s := spinner.New(o.Out, spinnerMsg("Remove kubeconfig from %s", defaultKubeConfigPath))
 	defer s.Fail()
 	if err := kubeConfigRemove(o.prevCluster.KubeConfig, defaultKubeConfigPath); err != nil {
 		if os.IsNotExist(err) {

pkg/cmd/playground/init.go

@@ -227,7 +227,7 @@ func (o *initOptions) local() error {
 	}
 
 	// create a local kubernetes cluster (k3d cluster) to deploy KubeBlocks
-	s := spinner.New(o.Out, spinnerMsg("Create k3d cluster: "+clusterInfo.ClusterName))
+	s := spinner.New(o.Out, spinnerMsg("Create k3d cluster: %s", clusterInfo.ClusterName))
 	defer s.Fail()
 	if err = provider.CreateK8sCluster(clusterInfo); err != nil {
 		return errors.Wrap(err, "failed to set up k3d cluster")
@@ -379,7 +379,7 @@ func (o *initOptions) writeStateFile(provider cp.Interface) (*cp.K8sClusterInfo,
 
 // merge created kubernetes cluster kubeconfig to ~/.kube/config and set it as default
 func (o *initOptions) setKubeConfig(info *cp.K8sClusterInfo) error {
-	s := spinner.New(o.Out, spinnerMsg("Merge kubeconfig to "+defaultKubeConfigPath))
+	s := spinner.New(o.Out, spinnerMsg("Merge kubeconfig to %s", defaultKubeConfigPath))
 	defer s.Fail()
 
 	// check if the default kubeconfig file exists, if not, create it
@@ -399,7 +399,7 @@ func (o *initOptions) setKubeConfig(info *cp.K8sClusterInfo) error {
 	s.Success()
 
 	currentContext, err := kubeConfigCurrentContext(info.KubeConfig)
-	s = spinner.New(o.Out, spinnerMsg("Switch current context to "+currentContext))
+	s = spinner.New(o.Out, spinnerMsg("Switch current context to %s", currentContext))
 	defer s.Fail()
 	if err != nil {
 		return err

pkg/cmd/playground/util.go

@@ -123,7 +123,7 @@ func readClusterInfoFromFile(path string) (*cp.K8sClusterInfo, error) {
 }
 
 func writeAndUseKubeConfig(kubeConfig string, kubeConfigPath string, out io.Writer) error {
-	s := spinner.New(out, spinnerMsg("Write kubeconfig to "+kubeConfigPath))
+	s := spinner.New(out, spinnerMsg("Write kubeconfig to %s", kubeConfigPath))
 	defer s.Fail()
 	if err := kubeConfigWrite(kubeConfig, kubeConfigPath, writeKubeConfigOptions{
 		UpdateExisting:       true,