@@ -27,11 +27,10 @@ import (
2727 opsv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1"
2828 parametersv1alpha1 "github.com/apecloud/kubeblocks/apis/parameters/v1alpha1"
2929 "github.com/apecloud/kubeblocks/pkg/client/clientset/versioned"
30- cfgcm "github.com/apecloud/kubeblocks/pkg/configuration/config_manager"
31- "github.com/apecloud/kubeblocks/pkg/configuration/core"
32- configctrl "github.com/apecloud/kubeblocks/pkg/controller/configuration"
33- controllerutil "github.com/apecloud/kubeblocks/pkg/controllerutil"
3430 "github.com/apecloud/kubeblocks/pkg/generics"
31+ configctrl "github.com/apecloud/kubeblocks/pkg/parameters"
32+ cfgcm "github.com/apecloud/kubeblocks/pkg/parameters/configmanager"
33+ "github.com/apecloud/kubeblocks/pkg/parameters/core"
3534 "github.com/spf13/cobra"
3635 "k8s.io/cli-runtime/pkg/genericiooptions"
3736 cmdutil "k8s.io/kubectl/pkg/cmd/util"
@@ -115,7 +114,7 @@ func (o *configOpsOptions) validateReconfigureOptions() error {
115114 if err != nil {
116115 return err
117116 }
118- o .KeyValues = core . FromStringPointerMap (kvs )
117+ o .KeyValues = fromStringPointerMap (kvs )
119118 }
120119 return nil
121120}
@@ -174,7 +173,7 @@ func (o *configOpsOptions) validateConfigParams(rctx *ReconfigureContext, classi
174173 transform := func (params map [string ]* parametersv1alpha1.ParametersInFile ) []core.ParamPairs {
175174 var result []core.ParamPairs
176175 for file , ps := range params {
177- configDescs := controllerutil .GetComponentConfigDescriptions (& rctx .ConfigRender .Spec , file )
176+ configDescs := configctrl .GetComponentConfigDescriptions (& rctx .ConfigRender .Spec , file )
178177 builder := configctrl .NewValueManager (rctx .ParametersDefs , configDescs )
179178 updatedParams , _ := core .FromStringMap (ps .Parameters , builder .BuildValueTransformer (file ))
180179 result = append (result , core.ParamPairs {
@@ -187,7 +186,7 @@ func (o *configOpsOptions) validateConfigParams(rctx *ReconfigureContext, classi
187186
188187 restart := false
189188 for _ , parameters := range classifyParameters {
190- _ , err := controllerutil .MergeAndValidateConfigs (mockEmptyData (parameters ), transform (parameters ), rctx .ParametersDefs , rctx .ConfigRender .Spec .Configs )
189+ _ , err := configctrl .MergeAndValidateConfigs (mockEmptyData (parameters ), transform (parameters ), rctx .ParametersDefs , rctx .ConfigRender .Spec .Configs )
191190 if err != nil {
192191 return err
193192 }
@@ -210,6 +209,15 @@ func mockEmptyData(m map[string]*parametersv1alpha1.ParametersInFile) map[string
210209 return r
211210}
212211
212+ func fromStringPointerMap (m map [string ]string ) map [string ]* string {
213+ r := make (map [string ]* string , len (m ))
214+ for key , value := range m {
215+ v := value
216+ r [key ] = & v
217+ }
218+ return r
219+ }
220+
213221func (o * configOpsOptions ) confirmReconfigureWithRestart () error {
214222 if o .AutoApprove {
215223 return nil
0 commit comments