feat: tidy preflight internal types (#678)

Author: shanshanying

Makefile

@@ -256,13 +256,16 @@ install-docker-buildx: ## Create `docker buildx` builder.
 		echo "Buildx builder $(BUILDX_BUILDER) already exists"; \
 	fi
 
+GOLANGCILINT_VERSION ?= v2.8.0
+GOLANGCILINT_EXPECTED_VERSION = $(patsubst v%,%,$(GOLANGCILINT_VERSION))
+GOLANGCILINT_GOBIN_VERSION = $(shell [ -x "$(GOBIN)/golangci-lint" ] && $(GOBIN)/golangci-lint version 2>/dev/null | sed -n 's/.*version \([0-9.]*\).*/\1/p' | head -1)
+
 .PHONY: golangci
-golangci: GOLANGCILINT_VERSION = v2.8.0
 golangci: ## Download golangci-lint locally if necessary.
-ifeq ($(shell golangci-lint version >/dev/null 2>&1 && echo ok),ok)
-	@echo golangci-lint is already installed
-GOLANGCILINT=$(shell which golangci-lint)
-else ifeq (, $(shell which $(GOBIN)/golangci-lint))
+ifeq ($(GOLANGCILINT_EXPECTED_VERSION),$(GOLANGCILINT_GOBIN_VERSION))
+	@echo golangci-lint $(GOLANGCILINT_VERSION) is already installed
+GOLANGCILINT=$(GOBIN)/golangci-lint
+else
 	@{ \
 	set -e ;\
 	echo 'installing golangci-lint-$(GOLANGCILINT_VERSION)' ;\
@@ -273,9 +276,6 @@ else ifeq (, $(shell which $(GOBIN)/golangci-lint))
 	echo 'Successfully installed' ;\
 	}
 GOLANGCILINT=$(GOBIN)/golangci-lint
-else
-	@echo golangci-lint is already installed
-GOLANGCILINT=$(GOBIN)/golangci-lint
 endif
 
 .PHONY: staticchecktool

go.mod

@@ -46,25 +46,3 @@ spec:
               message: The volumesnapshotcontents CRD was not found in the cluster.
           - pass:
               message: volumesnapshotcontents is installed.
-  extendAnalyzers:
-    - clusterAccess:
-        checkName: Check-K8S-Access
-        outcomes:
-          - fail:
-              message: K8s cluster access fail
-          - pass:
-              message: K8s cluster access ok
-    - taint:
-        checkName: Required-Taint-Match
-        outcomes:
-          - fail:
-              message: All nodes had taints that the pod didn't tolerate
-          - pass:
-              message: The taint matching succeeded
-    - storageClass:
-        checkName: Required-Default-SC
-        outcomes:
-          - warn:
-              message: The default storage class was not found. You can use option --set storageClass=<storageClassName> when creating cluster
-          - pass:
-              message: Default storage class is the presence, and all good on storage classes