feat: tidy preflight internal types#678
Merged
Merged
Conversation
shanshanying
requested review from
1aal,
ldming,
nayutah and
wangyelei
as code owners
shanshanying
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
=======================================
Coverage 39.93% 39.93%
=======================================
Files 172 172
Lines 24024 24024
=======================================
Hits 9595 9595
Misses 13308 13308
Partials 1121 1121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/approve to trigger test |
apecloud-bot
approved these changes
May 26, 2026
Keep KubeBlocks preflight on the native troubleshoot Preflight API and limit the default checks to cluster-side requirements: Kubernetes version, node count, and required VolumeSnapshot CRDs. Remove host preflight loading and execution, provider-specific preflight YAMLs, and the KubeBlocks-specific extend analyzer/collector/type layers that were only used by the removed checks. Update tests and fixtures for native Preflight-only parsing and execution. Do not upgrade github.com/replicatedhq/troubleshoot because v0.123.0 requires a newer Kubernetes dependency stack than this branch currently supports.
Pin github.com/cyphar/filepath-securejoin to v0.5.1 via replace. containers/storage v1.59.1 still imports the legacy OpenInRoot and Reopen wrappers from the root package, while v0.6.x removes those wrappers. v0.5.1 keeps the legacy root-package wrappers and still provides pathrs-lite for opencontainers/selinux, which fixes the golangci-lint typecheck failure on Linux without changing the troubleshoot version.
shanshanying
force-pushed
the
feature/tidy-preflight-internal-types
branch
from
368c0cd to
39e6501
Compare
ldming
approved these changes
May 27, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep KubeBlocks preflight on the native troubleshoot Preflight API and limit the default checks to cluster-side requirements: Kubernetes version, node count, and required VolumeSnapshot CRDs.
Remove host preflight loading and execution, provider-specific preflight YAMLs, and the KubeBlocks-specific extend analyzer/collector/type layers that were only used by the removed checks.
Update tests and fixtures for native Preflight-only parsing and execution.