Skip to content

fix: null type of values schema #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loomts merged 2 commits into from
Jun 4, 2025
Merged

fix: null type of values schema #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
940814f
fix null type of values schema
loomts Jun 4, 2025
2832083
fix test
loomts Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cmd/kubeblocks/kubeblocks_objects_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ func mockCRD() []runtime.Object {
APIVersion: "apiextensions.k8s.io/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "clusterversions.apps.kubeblocks.io",
Name: "clusterversions.apps.kubeblocks.io",
Labels: label,
},
Spec: v1.CustomResourceDefinitionSpec{
Group: types.AppsAPIGroup,
Expand Down
5 changes: 5 additions & 0 deletions pkg/util/flags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const (
)

const (
typeNull = "null"
typeString = "string"
typeNumber = "number"
typeInteger = "integer"
Expand Down Expand Up @@ -123,6 +124,8 @@ func buildOneFlag(cmd *cobra.Command, k string, s *spec.Schema, isArray bool) er
}
case typeArray:
return fmt.Errorf("unsupported build flags for object with array nested within an array")
case typeNull:
return nil
default:
return fmt.Errorf("unsupported json schema type %s", s.Type)
}
Expand All @@ -148,6 +151,8 @@ func buildOneFlag(cmd *cobra.Command, k string, s *spec.Schema, isArray bool) er
if err := buildOneFlag(cmd, name, s.Items.Schema, true); err != nil {
return err
}
case typeNull:
return nil
default:
return fmt.Errorf("unsupported json schema type %s", s.Type)
}
Expand Down