Skip to content

feat(rabbitmq): add 4.3.1 service version#2707

Open
weicao wants to merge 5 commits into
jasper/rabbitmq-init-account-compatfrom
jasper/rabbitmq-4.3.1-support
Open

feat(rabbitmq): add 4.3.1 service version#2707
weicao wants to merge 5 commits into
jasper/rabbitmq-init-account-compatfrom
jasper/rabbitmq-4.3.1-support

Conversation

@weicao
Copy link
Copy Markdown
Contributor

@weicao weicao commented May 31, 2026

Summary

  • add RabbitMQ serviceVersion 4.3.1 using docker.io/rabbitmq:4.3.1-management
  • refresh README supported-version list and fix stale 3.8 doc entry to 3.8.34

Validation

  • Docker Hub official image listing shows 4.3.1-management exists
  • helm template rabbitmq addons/rabbitmq renders serviceVersion 4.3.1 and image docker.io/rabbitmq:4.3.1-management
  • kubeblocks-tests/rabbitmq static suite passed PASS=20 FAIL=0 SKIP=0

Boundary

This is a child PR on top of the current RabbitMQ init-account candidate branch. It creates a new candidate SHA and needs fresh runtime validation before being counted as release evidence.

@weicao weicao requested review from a team, leon-ape and xuriwuyun as code owners May 31, 2026 13:15
@weicao
Copy link
Copy Markdown
Contributor Author

weicao commented May 31, 2026

Update after westonnnn image-source directive (2026-05-31 22:12 BJT)

Pushed c82c9a6b5b329947a535f6e4b464bd71781c68f7 to prefer ACR for RabbitMQ images by default:

  • image.registry = apecloud-registry.cn-zhangjiakou.cr.aliyuncs.com
  • image.repository = apecloud/rabbitmq

Validation performed locally:

  • helm template rabbitmq addons/rabbitmq --namespace kb-system renders serviceVersion: 4.3.1 with apecloud-registry.cn-zhangjiakou.cr.aliyuncs.com/apecloud/rabbitmq:4.3.1-management.
  • ACR registry API confirms all 10 RabbitMQ version tags in the matrix exist with OCI index + linux/amd64 manifests.
  • git diff --check passed.
  • With kubeblocks-tests chore: support redis sentinel #70 head fe2eb2c6, ADDONS_REPO=<this repo> RABBITMQ_STORAGE_GI=1 ./run-tests.sh --test static passed PASS=20 FAIL=0 SKIP=0.

CI is now running on the pushed commit.

Boundary: this closes addon-side image-source/render/static validation for 4.3.1, but runtime smoke/versions still needs a usable vcluster/runner; it should use ACR images and does not need to wait for the original node3 soak scene if run as a scoped 4.3.1 validation.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (5fb392f) to head (be8f5ce).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           jasper/rabbitmq-init-account-compat   #2707   +/-   ##
===================================================================
  Coverage                                 0.00%   0.00%           
===================================================================
  Files                                       73      73           
  Lines                                     9197    9197           
===================================================================
  Misses                                    9197    9197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weicao
Copy link
Copy Markdown
Contributor Author

weicao commented May 31, 2026

CI checkpoint after ACR update (2026-05-31 22:45 BJT)

Head c82c9a6b5b329947a535f6e4b464bd71781c68f7 is now CLEAN / MERGEABLE; all current checks are green:

  • check-addons-helm / release-chart
  • check-addons-helm (dockerhub) / release-chart
  • check-addons-helm (aliyun) / release-chart
  • check-addons-cluster-helm / release-chart
  • generate-files
  • shell-check
  • shellspec-test

Addon-side status: ACR image-source change + 4.3.1 render/static validation are closed on this PR.

Runtime boundary: scoped 4.3.1 runtime smoke/versions still needs a usable vcluster kubeconfig/runner entry that can pull ACR. This is independent from the older Rule 12 soak attempt blocked by the original node3 host/kubelet issue.

@weicao
Copy link
Copy Markdown
Contributor Author

weicao commented May 31, 2026

Follow-up pushed: e67de30976712e9eebecef0596a40c2caedeb209 adds 4.3.1 to addons-cluster/rabbitmq/values.schema.json.\n\nWhy: local static validation found the addon chart rendered 4.3.1, but the cluster chart schema still rejected --set version=4.3.1.\n\nValidation after fix:\n- ADDONS_REPO=../kubeblocks-addons RABBITMQ_STORAGE_GI=1 rabbitmq/run-tests.sh --test static --service-version 4.3.1 => PASS=20 FAIL=0 SKIP=0\n\nBoundary: this is still code/static validation; runtime PASS remains separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants