Skip to content

Commit 05a401e

Browse files
weicaoapecloud-bot
authored andcommitted
chore(parameters): treat nil and empty ConfigItemDetails as equal (#10420)
(cherry picked from commit db9c15c)
1 parent cd3d071 commit 05a401e

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

controllers/parameters/componentdrivenparameter_controller.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ func (r *ComponentDrivenParameterReconciler) delete(reqCtx intctrlutil.RequestCt
142142

143143
func (r *ComponentDrivenParameterReconciler) update(reqCtx intctrlutil.RequestCtx, expected, existing *parametersv1alpha1.ComponentParameter) (ctrl.Result, error) {
144144
mergedObject := r.mergeComponentParameter(expected, existing)
145+
if len(mergedObject.Spec.ConfigItemDetails) == 0 && len(existing.Spec.ConfigItemDetails) == 0 {
146+
mergedObject.Spec.ConfigItemDetails = existing.Spec.ConfigItemDetails
147+
}
145148
if reflect.DeepEqual(mergedObject, existing) {
146149
return intctrlutil.Reconciled()
147150
}

0 commit comments

Comments
 (0)