chore: patch metadata-only pod updates#10403
Merged
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
leon-ape
approved these changes
Jun 18, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #10403 +/- ##
===============================================
+ Coverage 53.86% 53.94% +0.08%
===============================================
Files 494 494
Lines 55688 55698 +10
===============================================
+ Hits 29994 30049 +55
+ Misses 22706 22654 -52
- Partials 2988 2995 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
/recheck-cla |
|
✅ CLA recheck triggered. The status should update shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a successful reconfigure, the remaining Pod diff can be metadata-only, for example a config-hash annotation update. The release-1.0 InstanceSet path already skips switchover for safe metadata-only in-place updates, but
ObjectTree.Updatestill plans a full update. That can leave the Pod metadata stale when the update path should use a merge patch.Changes
ObjectTreepatch option and plan a PATCH vertex when requested.Backport boundary
This is a manual release-1.0 backport of #10401.
release-1.0does not have the separatepkg/controller/instancereconciler path frommain, so this PR intentionally changes only the release-1.0 InstanceSet path plus sharedkubebuilderxplanning code.Validation
go generate -x ./pkg/testutil/k8s/mocks/...go test ./pkg/controller/kubebuilderx ./pkg/controller/instanceset -count=1git diff --check origin/release-1.0..HEADBackport for #10369 via #10401.