Skip to content

chore: patch metadata-only pod updates#10403

Merged
leon-ape merged 1 commit into
release-1.0from
bugfix/release-1.0-metadata-only-pod-patch
Jun 18, 2026
Merged

chore: patch metadata-only pod updates#10403
leon-ape merged 1 commit into
release-1.0from
bugfix/release-1.0-metadata-only-pod-patch

Conversation

@weicao

@weicao weicao commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Problem

After a successful reconfigure, the remaining Pod diff can be metadata-only, for example a config-hash annotation update. The release-1.0 InstanceSet path already skips switchover for safe metadata-only in-place updates, but ObjectTree.Update still plans a full update. That can leave the Pod metadata stale when the update path should use a merge patch.

Changes

  • Add an ObjectTree patch option and plan a PATCH vertex when requested.
  • Use PATCH for safe metadata-only in-place Pod updates in the release-1.0 InstanceSet reconciler.
  • Add focused coverage for PATCH planning and the InstanceSet metadata-only call site.

Backport boundary

This is a manual release-1.0 backport of #10401. release-1.0 does not have the separate pkg/controller/instance reconciler path from main, so this PR intentionally changes only the release-1.0 InstanceSet path plus shared kubebuilderx planning code.

Validation

  • go generate -x ./pkg/testutil/k8s/mocks/...
  • go test ./pkg/controller/kubebuilderx ./pkg/controller/instanceset -count=1
  • git diff --check origin/release-1.0..HEAD

Backport for #10369 via #10401.

@weicao weicao requested a review from a team as a code owner June 18, 2026 06:33
@weicao weicao requested a review from leon-ape June 18, 2026 06:33
@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label Jun 18, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@weicao weicao changed the title fix: patch metadata-only pod updates chore: patch metadata-only pod updates Jun 18, 2026
@leon-ape leon-ape added the nopick Not auto cherry-pick when PR merged label Jun 18, 2026
@leon-ape leon-ape modified the milestone: Release 1.1.0 Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.94%. Comparing base (fb30697) to head (4d3a848).
⚠️ Report is 1 commits behind head on release-1.0.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0   #10403      +/-   ##
===============================================
+ Coverage        53.86%   53.94%   +0.08%     
===============================================
  Files              494      494              
  Lines            55688    55698      +10     
===============================================
+ Hits             29994    30049      +55     
+ Misses           22706    22654      -52     
- Partials          2988     2995       +7     
Flag Coverage Δ
unittests 53.94% <89.47%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 18, 2026
@leon-ape

Copy link
Copy Markdown
Contributor

/recheck-cla

@github-actions

Copy link
Copy Markdown

✅ CLA recheck triggered. The status should update shortly.

@leon-ape leon-ape merged commit cd3d071 into release-1.0 Jun 18, 2026
48 of 49 checks passed
@leon-ape leon-ape deleted the bugfix/release-1.0-metadata-only-pod-patch branch June 18, 2026 06:55
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants