Add unit tests for SingleSignOutHandler and AuthenticationFilter#1139
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Add unit tests for SingleSignOutHandler and AuthenticationFilter#1139vasiliy-mikhailov wants to merge 1 commit into
vasiliy-mikhailov wants to merge 1 commit into
Conversation
vasiliy-mikhailov
force-pushed
the
tests/sso-handler-auth-filter
branch
from
June 27, 2026 07:44
2caf6c7 to
bd6587c
Compare
Cover previously-untested branches and edge cases in two cas-client-core classes. No production code changes. Signed-off-by: Vasiliy Mikhailov <vasiliy.mikhailov@gmail.com>
vasiliy-mikhailov
force-pushed
the
tests/sso-handler-auth-filter
branch
from
June 27, 2026 07:46
bd6587c to
fb6557f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests covering previously-untested branches and edge cases in two cas-client-core classes. No production code is changed.
SingleSignOutHandler (+28 tests): constructor defaults, init idempotency and safe-parameter handling, logout detection across HTTP methods and content types (multipart casing, JSONP callback), session destruction with blank or absent tokens, and decompression edge cases.
AuthenticationFilter (+29 tests): filter-chain invocation with and without a ticket, renew and gateway combinations, redirect behavior when no ticket or assertion is present, ignore-pattern matching, and initialization variants.
All cas-client-core tests pass: mvn -pl cas-client-core test on JDK 21.
How this was produced
This PR was generated with an AI-assisted pipeline built around mutation testing (PIT). The pipeline mutates the target class (flipping conditions and changing boundary/edge cases) and runs the existing tests against each mutant. Where a mutant survives (the existing tests do not catch that edge case), it writes a focused test for that case and reruns PIT to confirm the new test actually kills that specific mutant. So every added test is verified to catch a concrete edge case the suite missed before, rather than being speculative or redundant. The change is additive only (no production code modified), and the module builds green under its CI JDK.