Fix E_DEPRECATED messages when running against PHP 8.5

Fixes #448

Author: prigaux

source/CAS/Client.php

@@ -788,7 +788,7 @@ public function markAuthenticationCall ($auth)
             'file' => $dbg[1]['file'],
             'line' => $dbg[1]['line'],
             'method' => $dbg[1]['class'] . '::' . $dbg[1]['function'],
-            'result' => (boolean)$auth
+            'result' => (bool)$auth
         );
     }
     private $_authentication_caller;
@@ -3166,7 +3166,7 @@ public function getProxiedService ($type)
                 $proxiedService->setCasClient($this);
             }
             return $proxiedService;
-        case PHPCAS_PROXIED_SERVICE_IMAP;
+        case PHPCAS_PROXIED_SERVICE_IMAP:
             $proxiedService = new CAS_ProxiedService_Imap($this->_getUser());
             if ($proxiedService instanceof CAS_ProxiedService_Testable) {
                 $proxiedService->setCasClient($this);

test/CAS/Tests/CallbackTest.php

@@ -73,7 +73,9 @@ public static function setUpBeforeClass(): void
 
         $class = new \ReflectionClass('\CAS_Client');
         $method = $class->getMethod('isXmlResponse');
-        $method->setAccessible(true);
+        if (PHP_VERSION_ID < 80100) {
+            $method->setAccessible(true);
+        }
         self::$isXmlResponse = $method;
     }
 
@@ -94,7 +96,7 @@ public function testAcceptXML($accept, $expected)
         $this->assertEquals($expected, self::$isXmlResponse->invokeArgs(self::$client, array()), $accept);
     }
 
-    public function acceptXMLDataProvider()
+    public static function acceptXMLDataProvider()
     {
         return array(
             array(false, false),

test/CAS/Tests/CookieJarTest.php

@@ -81,19 +81,8 @@ class CookieJarTest extends TestCase
      */
     protected $object;
 
-    /**
-     * Sets up the fixture, for example, opens a network connection.
-     * This method is called before a test is executed.
-     *
-     * @return void
-     */
-    protected function setUp(): void
-    {
-        $this->cookieArray = array();
-        $this->object = new CookieJarExposed($this->cookieArray);
-
-        $this->serviceUrl_1 = 'http://service.example.com/lookup/?action=search&query=username';
-        $this->responseHeaders_1 = array('HTTP/1.1 302 Found',
+    protected $serviceUrl_1 = 'http://service.example.com/lookup/?action=search&query=username';
+    protected $responseHeaders_1 = array('HTTP/1.1 302 Found',
             'Date: Tue, 07 Sep 2010 17:51:54 GMT',
             'Server: Apache/2.2.3 (Red Hat)', 'X-Powered-By: PHP/5.1.6',
             'Set-Cookie: SID=k1jut1r1bqrumpei837kk4jks0; path=/',
@@ -104,8 +93,19 @@ protected function setUp(): void
             'Content-Length: 525', 'Connection: close',
             'Content-Type: text/html; charset=UTF-8',
         );
-        $this->serviceUrl_1b = 'http://service.example.com/lookup/?action=search&query=another_username';
-        $this->serviceUrl_1c = 'http://service.example.com/make_changes.php';
+    protected $serviceUrl_1b = 'http://service.example.com/lookup/?action=search&query=another_username';
+    protected $serviceUrl_1c = 'http://service.example.com/make_changes.php';
+
+    /**
+     * Sets up the fixture, for example, opens a network connection.
+     * This method is called before a test is executed.
+     *
+     * @return void
+     */
+    protected function setUp(): void
+    {
+        $cookieArray = array();
+        $this->object = new CookieJarExposed($cookieArray);
 
         // Verify that there are no cookies to start.
         $this->assertEquals(

test/CAS/Tests/ProxyChainsTest.php

@@ -48,27 +48,28 @@ class ProxyChainsTest extends TestCase
      */
     protected $object;
 
-    /**
-     * Sets up the fixture, for example, opens a network connection.
-     * This method is called before a test is executed.
-     */
-    protected function setUp(): void
-    {
-        $this->object = new \CAS_ProxyChain_AllowedList;
-        $this->list_size_0 = array();
-        $this->list_size_1 = array('https://service1.example.com/rest',);
-        $this->list_size_2 = array('https://service1.example.com/rest',
+    protected $list_size_0 = array();
+    protected $list_size_1 = array('https://service1.example.com/rest',);
+    protected $list_size_2 = array('https://service1.example.com/rest',
             'http://service2.example.com/my/path',
         );
-        $this->list_size_3 = array('https://service1.example.com/rest',
+    protected $list_size_3 = array('https://service1.example.com/rest',
             'http://service2.example.com/my/path',
             'http://service3.example.com/other/',
         );
-        $this->list_size_4 = array('https://service1.example.com/rest',
+    protected $list_size_4 = array('https://service1.example.com/rest',
             'http://service2.example.com/my/path',
             'http://service3.example.com/other/',
             'https://service4.example.com/',
         );
+
+    /**
+     * Sets up the fixture, for example, opens a network connection.
+     * This method is called before a test is executed.
+     */
+    protected function setUp(): void
+    {
+        $this->object = new \CAS_ProxyChain_AllowedList;
     }
 
     /**