Skip to content

WebUi challenge 1. Created fancy wifi list.#12

Open
paras151 wants to merge 1 commit into
apertus-open-source-cinema:mainfrom
paras151:task1
Open

WebUi challenge 1. Created fancy wifi list.#12
paras151 wants to merge 1 commit into
apertus-open-source-cinema:mainfrom
paras151:task1

Conversation

@paras151

Copy link
Copy Markdown

I believe the the wifi table data, uses keys as 0,1,2,3... and they already occur in a sorted manner in the output.

@rroohhh rroohhh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, great start already, some general notes:

  1. The whole UI is using material design which usually means a bit of padding between different elements, and furthermore not such strong color contrasts, as between the table header background and the rows.
  2. Please make sure your code is properly formatted, you can run the autoformatter using npm run format

Furthermore, I think adding sorting to the table would be great. Additionally, the security column could be make nicer using chips. Finally I think it would be great to highlight the current wifi network in use, using for example either bold font or maybe a different backgorund for the row.

@paras151

Copy link
Copy Markdown
Author

Thanks @rroohhh for the suggestions. One thing I would like to ask is on what basis should I sort the table?

@rroohhh

rroohhh commented Mar 18, 2021

Copy link
Copy Markdown
Member

@paras151 I think the best option would be to make the table sortable after a user selectable column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants