WebUi challenge 1. Created fancy wifi list.#12
Open
paras151 wants to merge 1 commit into
Open
Conversation
rroohhh
requested changes
Mar 17, 2021
rroohhh
left a comment
Member
There was a problem hiding this comment.
Hi, great start already, some general notes:
- The whole UI is using material design which usually means a bit of padding between different elements, and furthermore not such strong color contrasts, as between the table header background and the rows.
- Please make sure your code is properly formatted, you can run the autoformatter using
npm run format
Furthermore, I think adding sorting to the table would be great. Additionally, the security column could be make nicer using chips. Finally I think it would be great to highlight the current wifi network in use, using for example either bold font or maybe a different backgorund for the row.
Author
|
Thanks @rroohhh for the suggestions. One thing I would like to ask is on what basis should I sort the table? |
Member
|
@paras151 I think the best option would be to make the table sortable after a user selectable column. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the the wifi table data, uses keys as 0,1,2,3... and they already occur in a sorted manner in the output.