fix phpstan due to typeDeclarations: true

Maxcastel · Maxcastel · commit 13ac7ada72bf · 2026-03-30T14:57:12.000+02:00
diff --git a/src/GraphQl/Tests/Type/TypeBuilderTest.php b/src/GraphQl/Tests/Type/TypeBuilderTest.php
@@ -54,7 +54,6 @@ class TypeBuilderTest extends TestCase
     use ProphecyTrait;
 
     private ObjectProphecy $typesContainerProphecy;
-    /** @var callable */
     private \Closure $defaultFieldResolver;
     private ObjectProphecy $fieldsBuilderLocatorProphecy;
     private TypeBuilder $typeBuilder;
diff --git a/src/Metadata/ApiResource.php b/src/Metadata/ApiResource.php
@@ -1099,9 +1099,6 @@ public function withTypes(array|string $types): static
         return $self;
     }
 
-    /**
-     * @return array|mixed|string|null
-     */
     public function getFormats(): string|array|null
     {
         return $this->formats;
@@ -1115,17 +1112,11 @@ public function withFormats(mixed $formats): static
         return $self;
     }
 
-    /**
-     * @return array|mixed|string|null
-     */
     public function getInputFormats(): string|array|null
     {
         return $this->inputFormats;
     }
 
-    /**
-     * @param mixed|null $inputFormats
-     */
     public function withInputFormats(string|array|null $inputFormats): static
     {
         $self = clone $this;
@@ -1134,17 +1125,11 @@ public function withInputFormats(string|array|null $inputFormats): static
         return $self;
     }
 
-    /**
-     * @return array|mixed|string|null
-     */
     public function getOutputFormats(): string|array|null
     {
         return $this->outputFormats;
     }
 
-    /**
-     * @param mixed|null $outputFormats
-     */
     public function withOutputFormats(string|array|null $outputFormats): static
     {
         $self = clone $this;
diff --git a/src/Metadata/GraphQl/Operation.php b/src/Metadata/GraphQl/Operation.php
@@ -21,19 +21,13 @@
 class Operation extends AbstractOperation
 {
     /**
-     * @param Link[]|null $links
-     * @param array{
-     *     class?: string|null,
-     *     name?: string,
-     * }|string|false|null $input {@see https://api-platform.com/docs/core/dto/#specifying-an-input-or-an-output-data-representation}
-     * @param array{
-     *     class?: string|null,
-     *     name?: string,
-     * }|string|false|null $output {@see https://api-platform.com/docs/core/dto/#specifying-an-input-or-an-output-data-representation}
+     * @param Link[]|null            $links
+     * @param string|null            $input     {@see https://api-platform.com/docs/core/dto/#specifying-an-input-or-an-output-data-representation}
+     * @param string|null            $output    {@see https://api-platform.com/docs/core/dto/#specifying-an-input-or-an-output-data-representation}
      * @param string|array|bool|null $mercure   {@see https://api-platform.com/docs/core/mercure}
      * @param string|bool|null       $messenger {@see https://api-platform.com/docs/core/messenger/#dispatching-a-resource-through-the-message-bus}
-     * @param string|callable|null   $provider  {@see https://api-platform.com/docs/core/state-providers/#state-providers}
-     * @param string|callable|null   $processor {@see https://api-platform.com/docs/core/state-processors/#state-processors}
+     * @param string|null            $provider  {@see https://api-platform.com/docs/core/state-providers/#state-providers}
+     * @param string|null            $processor {@see https://api-platform.com/docs/core/state-processors/#state-processors}
      */
     public function __construct(
         protected ?string $resolver = null,
diff --git a/src/Metadata/GraphQl/Query.php b/src/Metadata/GraphQl/Query.php
@@ -53,8 +53,8 @@ public function __construct(
         ?string $deprecationReason = null,
         ?array $filters = null,
         ?array $validationContext = null,
-        ?array $input = null,
-        ?array $output = null,
+        ?string $input = null,
+        ?string $output = null,
         $mercure = null,
         $messenger = null,
         ?int $urlGenerationStrategy = null,
diff --git a/src/Metadata/GraphQl/QueryCollection.php b/src/Metadata/GraphQl/QueryCollection.php
@@ -54,8 +54,8 @@ public function __construct(
         ?string $deprecationReason = null,
         ?array $filters = null,
         ?array $validationContext = null,
-        ?array $input = null,
-        ?array $output = null,
+        ?string $input = null,
+        ?string $output = null,
         $mercure = null,
         $messenger = null,
         ?int $urlGenerationStrategy = null,
diff --git a/src/Metadata/GraphQl/Subscription.php b/src/Metadata/GraphQl/Subscription.php
@@ -53,8 +53,8 @@ public function __construct(
         ?string $deprecationReason = null,
         ?array $filters = null,
         ?array $validationContext = null,
-        ?array $input = null,
-        ?array $output = null,
+        ?string $input = null,
+        ?string $output = null,
         $mercure = null,
         $messenger = null,
         ?int $urlGenerationStrategy = null,
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaChoiceRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaChoiceRestriction.php
@@ -106,7 +106,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return false;
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_STRING];
         }
@@ -116,7 +116,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             && $builtinType->isCollection()
             && \count($builtinType->getCollectionValueTypes()) > 0
         ) {
-            $types = array_unique(array_merge($types, array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $builtinType->getCollectionValueTypes())));
+            $types = array_unique(array_merge($types, array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $builtinType->getCollectionValueTypes())));
         }
 
         return \count($types) > 0 && \count(array_intersect($types, [LegacyType::BUILTIN_TYPE_STRING, LegacyType::BUILTIN_TYPE_INT, LegacyType::BUILTIN_TYPE_FLOAT])) > 0;
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaGreaterThanOrEqualRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaGreaterThanOrEqualRestriction.php
@@ -52,7 +52,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_INT];
         }
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaGreaterThanRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaGreaterThanRestriction.php
@@ -56,7 +56,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_INT];
         }
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaLengthRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaLengthRestriction.php
@@ -59,7 +59,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return $constraint instanceof Length && $type?->isIdentifiedBy(TypeIdentifier::STRING);
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_STRING];
         }
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaLessThanOrEqualRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaLessThanOrEqualRestriction.php
@@ -55,7 +55,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_INT];
         }
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaLessThanRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaLessThanRestriction.php
@@ -53,7 +53,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_INT];
         }
diff --git a/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaRangeRestriction.php b/src/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaRangeRestriction.php
@@ -63,7 +63,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):
             return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);
         }
 
-        $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
+        $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);
         if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {
             $types = [LegacyType::BUILTIN_TYPE_INT];
         }
diff --git a/tests/Fixtures/TestBundle/ApiResource/Issue6264/BackedEnumStringTrait.php b/tests/Fixtures/TestBundle/ApiResource/Issue6264/BackedEnumStringTrait.php
@@ -20,7 +20,7 @@ trait BackedEnumStringTrait
 {
     public static function values(): array
     {
-        return array_map(static fn (\BackedEnum $feature): int|string => $feature->value, self::cases());
+        return array_map(static fn (\BackedEnum $feature): string => $feature->value, self::cases());
     }
 
     public function getId(): string
diff --git a/tests/Fixtures/TestBundle/ApiResource/Issue6264/BackedEnumTrait.php b/tests/Fixtures/TestBundle/ApiResource/Issue6264/BackedEnumTrait.php
@@ -20,7 +20,7 @@ trait BackedEnumTrait
 {
     public static function values(): array
     {
-        return array_map(static fn (\BackedEnum $feature): int|string => $feature->value, self::cases());
+        return array_map(static fn (\BackedEnum $feature): int => $feature->value, self::cases());
     }
 
     public function getId(): int
diff --git a/tests/Fixtures/TestBundle/Entity/FooDummy.php b/tests/Fixtures/TestBundle/Entity/FooDummy.php
@@ -45,7 +45,7 @@ class FooDummy
     private $name;
 
     #[ORM\Column(nullable: true)]
-    private string $nonWritableProp;
+    private ?string $nonWritableProp = null;
 
     #[ApiProperty(readableLink: true, writableLink: true)]
     #[ORM\Embedded(class: FooEmbeddable::class)]

Original file line number	Diff line number	Diff line change
`@@ -1099,9 +1099,6 @@ public function withTypes(array\|string $types): static`
`1099`	`1099`	`return $self;`
`1100`	`1100`	`}`
`1101`	`1101`
`1102`		`- /**`
`1103`		`- * @return array\|mixed\|string\|null`
`1104`		`- */`
`1105`	`1102`	`public function getFormats(): string\|array\|null`
`1106`	`1103`	`{`
`1107`	`1104`	`return $this->formats;`
`@@ -1115,17 +1112,11 @@ public function withFormats(mixed $formats): static`
`1115`	`1112`	`return $self;`
`1116`	`1113`	`}`
`1117`	`1114`
`1118`		`- /**`
`1119`		`- * @return array\|mixed\|string\|null`
`1120`		`- */`
`1121`	`1115`	`public function getInputFormats(): string\|array\|null`
`1122`	`1116`	`{`
`1123`	`1117`	`return $this->inputFormats;`
`1124`	`1118`	`}`
`1125`	`1119`
`1126`		`- /**`
`1127`		`- * @param mixed\|null $inputFormats`
`1128`		`- */`
`1129`	`1120`	`public function withInputFormats(string\|array\|null $inputFormats): static`
`1130`	`1121`	`{`
`1131`	`1122`	`$self = clone $this;`
`@@ -1134,17 +1125,11 @@ public function withInputFormats(string\|array\|null $inputFormats): static`
`1134`	`1125`	`return $self;`
`1135`	`1126`	`}`
`1136`	`1127`
`1137`		`- /**`
`1138`		`- * @return array\|mixed\|string\|null`
`1139`		`- */`
`1140`	`1128`	`public function getOutputFormats(): string\|array\|null`
`1141`	`1129`	`{`
`1142`	`1130`	`return $this->outputFormats;`
`1143`	`1131`	`}`
`1144`	`1132`
`1145`		`- /**`
`1146`		`- * @param mixed\|null $outputFormats`
`1147`		`- */`
`1148`	`1133`	`public function withOutputFormats(string\|array\|null $outputFormats): static`
`1149`	`1134`	`{`
`1150`	`1135`	`$self = clone $this;`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):`
`106`	`106`	`return false;`
`107`	`107`	`}`
`108`	`108`
`109`		`- $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
	`109`	`+ $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
`110`	`110`	`if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {`
`111`	`111`	`$types = [LegacyType::BUILTIN_TYPE_STRING];`
`112`	`112`	`}`
`@@ -116,7 +116,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):`
`116`	`116`	`&& $builtinType->isCollection()`
`117`	`117`	`&& \count($builtinType->getCollectionValueTypes()) > 0`
`118`	`118`	`) {`
`119`		`- $types = array_unique(array_merge($types, array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $builtinType->getCollectionValueTypes())));`
	`119`	`+ $types = array_unique(array_merge($types, array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $builtinType->getCollectionValueTypes())));`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`return \count($types) > 0 && \count(array_intersect($types, [LegacyType::BUILTIN_TYPE_STRING, LegacyType::BUILTIN_TYPE_INT, LegacyType::BUILTIN_TYPE_FLOAT])) > 0;`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):`
`52`	`52`	`return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);`
`53`	`53`	`}`
`54`	`54`
`55`		`- $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
	`55`	`+ $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
`56`	`56`	`if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {`
`57`	`57`	`$types = [LegacyType::BUILTIN_TYPE_INT];`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):`
`56`	`56`	`return $type->isIdentifiedBy(TypeIdentifier::INT, TypeIdentifier::FLOAT);`
`57`	`57`	`}`
`58`	`58`
`59`		`- $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
	`59`	`+ $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
`60`	`60`	`if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {`
`61`	`61`	`$types = [LegacyType::BUILTIN_TYPE_INT];`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function supports(Constraint $constraint, ApiProperty $propertyMetadata):`
`59`	`59`	`return $constraint instanceof Length && $type?->isIdentifiedBy(TypeIdentifier::STRING);`
`60`	`60`	`}`
`61`	`61`
`62`		`- $types = array_map(static fn (LegacyType $type) => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
	`62`	`+ $types = array_map(static fn (LegacyType $type): string => $type->getBuiltinType(), $propertyMetadata->getBuiltinTypes() ?? []);`
`63`	`63`	`if ($propertyMetadata->getExtraProperties()['nested_schema'] ?? false) {`
`64`	`64`	`$types = [LegacyType::BUILTIN_TYPE_STRING];`
`65`	`65`	`}`