run rector with typeDeclarations to true

Author: Maxcastel

rector.php

@@ -29,9 +29,12 @@
         __DIR__.'/src/Doctrine/Odm/Tests/var',
         __DIR__.'/tests/Fixtures/app/config/reference.php',
         __DIR__.'/src/Symfony/Bundle/DependencyInjection/Configuration.php',
+        __DIR__.'/tests/Fixer/SymfonyServiceClassConstantFixer.php',
     ])
     // uncomment to reach your current PHP version
     // ->withPhpSets()
-    ->withTypeCoverageLevel(0)
+    ->withPreparedSets(
+        typeDeclarations: true,
+    )
     ->withDeadCodeLevel(0)
     ->withCodeQualityLevel(0);

src/Doctrine/Common/Filter/BackedEnumFilterTrait.php

@@ -59,7 +59,7 @@ public function getDescription(string $resourceClass): array
             foreach ($filterParameterNames as $filterParameterName) {
                 $isCollection = str_ends_with($filterParameterName, '[]');
 
-                $enumValues = array_map(static fn (\BackedEnum $case) => $case->value, $this->enumTypes[$property]::cases());
+                $enumValues = array_map(static fn (\BackedEnum $case): int|string => $case->value, $this->enumTypes[$property]::cases());
 
                 $schema = $isCollection
                     ? ['type' => 'array', 'items' => ['type' => 'string', 'enum' => $enumValues]]
@@ -99,7 +99,7 @@ private function normalizeValue(mixed $value, string $property): mixed
             $value = (int) $value;
         }
 
-        $values = array_map(static fn (\BackedEnum $case) => $case->value, $this->enumTypes[$property]::cases());
+        $values = array_map(static fn (\BackedEnum $case): int|string => $case->value, $this->enumTypes[$property]::cases());
 
         if (\in_array($value, $values, true)) {
             return $value;

src/Doctrine/Common/State/LinksHandlerLocatorTrait.php

@@ -58,7 +58,7 @@ private function findSimilarMethod(string $className, string $methodName): ?stri
     {
         $methods = get_class_methods($className);
 
-        $similarMethods = array_filter($methods, static function ($method) use ($methodName) {
+        $similarMethods = array_filter($methods, static function ($method) use ($methodName): bool {
             return levenshtein($methodName, $method) <= 3;
         });
 

src/Doctrine/Common/State/PersistProcessor.php

@@ -196,7 +196,7 @@ private function handleLazyObjectRelations(object $data, DoctrineObjectManager $
             $identifiers = $metadata->getIdentifierValues($value);
 
             // Do not get reference for partial objects or objects with null identifiers
-            if (!$identifiers || \count($identifiers) !== \count(array_filter($identifiers, static fn ($v) => null !== $v))) {
+            if (!$identifiers || \count($identifiers) !== \count(array_filter($identifiers, static fn ($v): bool => null !== $v))) {
                 continue;
             }
 

src/Doctrine/Common/Tests/CollectionPaginatorTest.php

@@ -21,7 +21,7 @@
 class CollectionPaginatorTest extends TestCase
 {
     #[DataProvider('initializeProvider')]
-    public function testInitialize($results, $currentPage, $itemsPerPage, $totalItems, $lastPage, $currentItems): void
+    public function testInitialize(array $results, int $currentPage, int $itemsPerPage, int $totalItems, int $lastPage, int $currentItems): void
     {
         $results = new ArrayCollection($results);
         $paginator = new CollectionPaginator($results, $currentPage, $itemsPerPage);

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/Dummy.php

@@ -209,7 +209,7 @@ public function getDummyDate()
         return $this->dummyDate;
     }
 
-    public function setDummyPrice($dummyPrice)
+    public function setDummyPrice($dummyPrice): static
     {
         $this->dummyPrice = $dummyPrice;
 
@@ -284,10 +284,7 @@ public function isDummyBoolean(): ?bool
         return $this->dummyBoolean;
     }
 
-    /**
-     * @param bool $dummyBoolean
-     */
-    public function setDummyBoolean($dummyBoolean): void
+    public function setDummyBoolean(?bool $dummyBoolean): void
     {
         $this->dummyBoolean = $dummyBoolean;
     }

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/RelatedDummy.php

@@ -148,10 +148,7 @@ public function isDummyBoolean(): ?bool
         return $this->dummyBoolean;
     }
 
-    /**
-     * @param bool $dummyBoolean
-     */
-    public function setDummyBoolean($dummyBoolean): void
+    public function setDummyBoolean(?bool $dummyBoolean): void
     {
         $this->dummyBoolean = $dummyBoolean;
     }

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/RelatedToDummyFriend.php

@@ -74,10 +74,7 @@ public function getDescription(): ?string
         return $this->description;
     }
 
-    /**
-     * @param string|null $description
-     */
-    public function setDescription($description): void
+    public function setDescription(?string $description): void
     {
         $this->description = $description;
     }

src/Doctrine/Common/Tests/Fixtures/TestBundle/Entity/ThirdLevel.php

@@ -61,10 +61,7 @@ public function getLevel(): ?int
         return $this->level;
     }
 
-    /**
-     * @param int $level
-     */
-    public function setLevel($level): void
+    public function setLevel(int $level): void
     {
         $this->level = $level;
     }
@@ -74,10 +71,7 @@ public function isTest(): bool
         return $this->test;
     }
 
-    /**
-     * @param bool $test
-     */
-    public function setTest($test): void
+    public function setTest(bool $test): void
     {
         $this->test = $test;
     }

src/Doctrine/Common/Tests/SelectablePaginatorTest.php

@@ -21,7 +21,7 @@
 class SelectablePaginatorTest extends TestCase
 {
     #[DataProvider('initializeProvider')]
-    public function testInitialize($results, $currentPage, $itemsPerPage, $totalItems, $lastPage, $currentItems): void
+    public function testInitialize(array $results, int $currentPage, int $itemsPerPage, int $totalItems, int $lastPage, int $currentItems): void
     {
         $results = new ArrayCollection($results);
         $paginator = new SelectablePaginator($results, $currentPage, $itemsPerPage);