Merge pull request #2633 from soyuka/test-input-false

Create a resource with a falsy input

Author: soyuka

features/main/input_output.feature

@@ -232,3 +232,16 @@ Feature: DTO input and output
       }
     }
     """
+
+  @createSchema
+  Scenario: Create a resource with no input
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "POST" request to "/dummy_dto_no_inputs" with body:
+    """
+    {
+      "foo": "test",
+      "bar": 1
+    }
+    """
+    Then the response status code should be 201
+    And the response should be empty

src/EventListener/SerializeListener.php

@@ -61,7 +61,14 @@ public function onKernelView(GetResponseForControllerResultEvent $event): void
 
         $context = $this->serializerContextBuilder->createFromRequest($request, true, $attributes);
 
-        if (isset($context['output']) && \array_key_exists('class', $context['output']) && null === $context['output']['class']) {
+        if (
+            (isset($context['output']) && \array_key_exists('class', $context['output']) && null === $context['output']['class'])
+            ||
+            (
+                null === $controllerResult && isset($context['input']) && \array_key_exists('class', $context['input']) &&
+                null === $context['input']['class']
+            )
+        ) {
             $event->setControllerResult('');
 
             return;

src/Validator/EventListener/ValidateListener.php

@@ -52,10 +52,13 @@ public function onKernelView(GetResponseForControllerResultEvent $event): void
             return;
         }
 
-        $data = $event->getControllerResult();
         $resourceMetadata = $this->resourceMetadataFactory->create($attributes['resource_class']);
-        $validationGroups = $resourceMetadata->getOperationAttribute($attributes, 'validation_groups', null, true);
+        $inputMetadata = $resourceMetadata->getOperationAttribute($attributes, 'input', [], true);
+        if (\array_key_exists('class', $inputMetadata) && null === $inputMetadata['class']) {
+            return;
+        }
 
-        $this->validator->validate($data, ['groups' => $validationGroups]);
+        $validationGroups = $resourceMetadata->getOperationAttribute($attributes, 'validation_groups', null, true);
+        $this->validator->validate($event->getControllerResult(), ['groups' => $validationGroups]);
     }
 }