Skip to content

Commit 8c8297a

Browse files
Maxcastelsoyuka
andauthored
refactor: use imported DataProvider instead of FQCN (#7753)
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
1 parent 03b18a5 commit 8c8297a

62 files changed

Lines changed: 158 additions & 96 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/Doctrine/Common/Tests/CollectionPaginatorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@
1515

1616
use ApiPlatform\Doctrine\Common\CollectionPaginator;
1717
use Doctrine\Common\Collections\ArrayCollection;
18+
use PHPUnit\Framework\Attributes\DataProvider;
1819
use PHPUnit\Framework\TestCase;
1920

2021
class CollectionPaginatorTest extends TestCase
2122
{
22-
#[\PHPUnit\Framework\Attributes\DataProvider('initializeProvider')]
23+
#[DataProvider('initializeProvider')]
2324
public function testInitialize($results, $currentPage, $itemsPerPage, $totalItems, $lastPage, $currentItems): void
2425
{
2526
$results = new ArrayCollection($results);

src/Doctrine/Common/Tests/SelectablePaginatorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@
1515

1616
use ApiPlatform\Doctrine\Common\SelectablePaginator;
1717
use Doctrine\Common\Collections\ArrayCollection;
18+
use PHPUnit\Framework\Attributes\DataProvider;
1819
use PHPUnit\Framework\TestCase;
1920

2021
class SelectablePaginatorTest extends TestCase
2122
{
22-
#[\PHPUnit\Framework\Attributes\DataProvider('initializeProvider')]
23+
#[DataProvider('initializeProvider')]
2324
public function testInitialize($results, $currentPage, $itemsPerPage, $totalItems, $lastPage, $currentItems): void
2425
{
2526
$results = new ArrayCollection($results);

src/Doctrine/Common/Tests/SelectablePartialPaginatorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@
1515

1616
use ApiPlatform\Doctrine\Common\SelectablePartialPaginator;
1717
use Doctrine\Common\Collections\ArrayCollection;
18+
use PHPUnit\Framework\Attributes\DataProvider;
1819
use PHPUnit\Framework\TestCase;
1920

2021
class SelectablePartialPaginatorTest extends TestCase
2122
{
22-
#[\PHPUnit\Framework\Attributes\DataProvider('initializeProvider')]
23+
#[DataProvider('initializeProvider')]
2324
public function testInitialize($results, $currentPage, $itemsPerPage, $currentItems): void
2425
{
2526
$results = new ArrayCollection($results);

src/Doctrine/Common/Tests/State/PersistProcessorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
use Doctrine\ORM\Mapping\ClassMetadata as ORMClassMetadata;
2424
use Doctrine\Persistence\ManagerRegistry;
2525
use Doctrine\Persistence\ObjectManager;
26+
use PHPUnit\Framework\Attributes\DataProvider;
2627
use PHPUnit\Framework\TestCase;
2728
use Prophecy\PhpUnit\ProphecyTrait;
2829
use Prophecy\Prediction\CallPrediction;
@@ -93,7 +94,7 @@ public static function getTrackingPolicyParameters(): array
9394
];
9495
}
9596

96-
#[\PHPUnit\Framework\Attributes\DataProvider('getTrackingPolicyParameters')]
97+
#[DataProvider('getTrackingPolicyParameters')]
9798
public function testTrackingPolicy(string $metadataClass, bool $deferredExplicit, bool $persisted): void
9899
{
99100
$dummy = new Dummy();

src/Doctrine/Odm/Tests/DoctrineMongoDbOdmFilterTestCase.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
use Doctrine\ODM\MongoDB\DocumentManager;
1818
use Doctrine\ODM\MongoDB\Repository\DocumentRepository;
1919
use Doctrine\Persistence\ManagerRegistry;
20+
use PHPUnit\Framework\Attributes\DataProvider;
2021
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
2122

2223
/**
@@ -45,7 +46,7 @@ protected function setUp(): void
4546
$this->repository = $this->manager->getRepository($this->resourceClass);
4647
}
4748

48-
#[\PHPUnit\Framework\Attributes\DataProvider('provideApplyTestData')]
49+
#[DataProvider('provideApplyTestData')]
4950
public function testApply(?array $properties, array $filterParameters, array $expectedPipeline, ?callable $factory = null, ?string $resourceClass = null): void
5051
{
5152
$this->doTestApply($properties, $filterParameters, $expectedPipeline, $factory, $resourceClass);

src/Doctrine/Odm/Tests/Metadata/Resource/DoctrineMongoDbOdmResourceCollectionMetadataFactoryTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
2828
use Doctrine\ODM\MongoDB\DocumentManager;
2929
use Doctrine\Persistence\ManagerRegistry;
30+
use PHPUnit\Framework\Attributes\DataProvider;
3031
use PHPUnit\Framework\TestCase;
3132
use Prophecy\PhpUnit\ProphecyTrait;
3233

@@ -70,7 +71,7 @@ public function testWithoutManager(): void
7071
$this->assertNull($resourceMetadataCollection->getOperation('graphql_get')->getProvider());
7172
}
7273

73-
#[\PHPUnit\Framework\Attributes\DataProvider('operationProvider')]
74+
#[DataProvider('operationProvider')]
7475
public function testWithProvider(HttpOperation $operation, ?string $expectedProvider = null, ?string $expectedProcessor = null): void
7576
{
7677
if (!class_exists(DocumentManager::class)) {

src/Doctrine/Odm/Tests/PaginatorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use ApiPlatform\Metadata\Exception\RuntimeException;
1919
use Doctrine\ODM\MongoDB\DocumentManager;
2020
use Doctrine\ODM\MongoDB\Iterator\Iterator;
21+
use PHPUnit\Framework\Attributes\DataProvider;
2122
use PHPUnit\Framework\Attributes\TestWith;
2223
use PHPUnit\Framework\TestCase;
2324
use Prophecy\PhpUnit\ProphecyTrait;
@@ -26,7 +27,7 @@ class PaginatorTest extends TestCase
2627
{
2728
use ProphecyTrait;
2829

29-
#[\PHPUnit\Framework\Attributes\DataProvider('initializeProvider')]
30+
#[DataProvider('initializeProvider')]
3031
public function testInitialize(int $firstResult, int $maxResults, int $totalItems, int $currentPage, int $lastPage, bool $hasNextPage): void
3132
{
3233
$paginator = $this->getPaginator($firstResult, $maxResults, $totalItems);

src/Doctrine/Odm/Tests/PropertyInfo/DoctrineExtractorTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
use Doctrine\Common\Collections\Collection;
2828
use Doctrine\ODM\MongoDB\DocumentManager;
2929
use Doctrine\ODM\MongoDB\Types\Type as MongoDbType;
30+
use PHPUnit\Framework\Attributes\DataProvider;
3031
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
3132
use PHPUnit\Framework\TestCase;
3233
use Symfony\Component\PropertyInfo\Type as LegacyType;
@@ -84,7 +85,7 @@ public function testTestGetPropertiesWithEmbedded(): void
8485
);
8586
}
8687

87-
#[\PHPUnit\Framework\Attributes\DataProvider('typesProvider')]
88+
#[DataProvider('typesProvider')]
8889
public function testExtract(string $property, ?Type $type): void
8990
{
9091
$this->assertEquals($type, $this->createExtractor()->getType(DoctrineDummy::class, $property));

src/Doctrine/Orm/Tests/DoctrineOrmFilterTestCase.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use ApiPlatform\Doctrine\Orm\Util\QueryNameGenerator;
1919
use Doctrine\ORM\EntityRepository;
2020
use Doctrine\Persistence\ManagerRegistry;
21+
use PHPUnit\Framework\Attributes\DataProvider;
2122
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
2223

2324
/**
@@ -45,7 +46,7 @@ protected function setUp(): void
4546
$this->repository = $this->managerRegistry->getManagerForClass(Dummy::class)->getRepository(Dummy::class);
4647
}
4748

48-
#[\PHPUnit\Framework\Attributes\DataProvider('provideApplyTestData')]
49+
#[DataProvider('provideApplyTestData')]
4950
public function testApply(?array $properties, array $filterParameters, string $expectedDql, ?array $expectedParameters = null, ?callable $factory = null, ?string $resourceClass = null): void
5051
{
5152
$this->doTestApply($properties, $filterParameters, $expectedDql, $expectedParameters, $factory, $resourceClass);

src/Doctrine/Orm/Tests/Extension/EagerLoadingExtensionTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
use Doctrine\ORM\Mapping\JoinColumn;
3939
use Doctrine\ORM\Query\Expr\Join;
4040
use Doctrine\ORM\QueryBuilder;
41+
use PHPUnit\Framework\Attributes\DataProvider;
4142
use PHPUnit\Framework\TestCase;
4243
use Prophecy\Argument;
4344
use Prophecy\PhpUnit\ProphecyTrait;
@@ -1000,7 +1001,7 @@ public function testApplyToCollectionWithANonReadableButFetchEagerProperty(): vo
10001001
$eagerExtensionTest->applyToCollection($queryBuilder, new QueryNameGenerator(), Dummy::class, new GetCollection(normalizationContext: [AbstractNormalizer::GROUPS => 'foo']));
10011002
}
10021003

1003-
#[\PHPUnit\Framework\Attributes\DataProvider('provideExistingJoinCases')]
1004+
#[DataProvider('provideExistingJoinCases')]
10041005
public function testApplyToCollectionWithExistingJoin(string $joinType): void
10051006
{
10061007
$context = ['groups' => ['foo']];

0 commit comments

Comments
 (0)