refactor(symfony): self-contained property_info chain with cache decoration

| Q             | A
| ------------- | ---
| Branch?       | main
| Tickets       | Fix #7876
| License       | MIT
| Doc PR        | Closes api-platform/docs#2262

Drop the PropertyInfoPass compiler pass and register a self-sufficient
extractor chain directly in api.php: ReflectionExtractor always, plus
PhpDocExtractor and PhpStanExtractor under class_exists guards. Decorate
api_platform.property_info with PropertyInfoCacheExtractor over the
cache.property_info pool so metadata extraction is cached regardless of
framework.property_info being enabled.

Extractors remain tagged on property_info.* so ecosystem extractors
(e.g. Doctrine's) still flow into the composite via tagged_iterator.

Author: soyuka

src/Symfony/Bundle/ApiPlatformBundle.php

@@ -24,7 +24,6 @@
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\JsonStreamerTransformerPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\MetadataAwareNameConverterPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\MutatorPass;
-use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\PropertyInfoPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\SerializerMappingLoaderPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\TestClientPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\TestMercureHubPass;
@@ -59,7 +58,6 @@ public function build(ContainerBuilder $container): void
         $container->addCompilerPass(new TestClientPass());
         $container->addCompilerPass(new TestMercureHubPass());
         $container->addCompilerPass(new AuthenticatorManagerPass());
-        $container->addCompilerPass(new PropertyInfoPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 200);
         $container->addCompilerPass(new SerializerMappingLoaderPass());
         $container->addCompilerPass(new MutatorPass());
         // Must run after Symfony's TransformerPass so we can rely on the value_object_transformer tag being processed.

src/Symfony/Bundle/DependencyInjection/Compiler/PropertyInfoPass.php

@@ -46,6 +46,14 @@
 use ApiPlatform\Symfony\Routing\Router;
 use ApiPlatform\Symfony\Routing\SkolemIriConverter;
 use Negotiation\Negotiator;
+use phpDocumentor\Reflection\DocBlockFactory;
+use phpDocumentor\Reflection\Types\ContextFactory;
+use PHPStan\PhpDocParser\Parser\PhpDocParser;
+use Symfony\Component\PropertyInfo\Extractor\ConstructorExtractor;
+use Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor;
+use Symfony\Component\PropertyInfo\Extractor\PhpStanExtractor;
+use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
+use Symfony\Component\PropertyInfo\PropertyInfoCacheExtractor;
 use Symfony\Component\PropertyInfo\PropertyInfoExtractor;
 use Symfony\Component\Serializer\Mapping\Factory\CacheClassMetadataFactory;
 use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
@@ -69,6 +77,29 @@
 
     $services->alias('api_platform.property_accessor', 'property_accessor');
 
+    $services->set('api_platform.property_info.reflection_extractor', ReflectionExtractor::class)
+        ->tag('property_info.list_extractor', ['priority' => -1000])
+        ->tag('property_info.type_extractor', ['priority' => -1002])
+        ->tag('property_info.access_extractor', ['priority' => -1000])
+        ->tag('property_info.initializable_extractor', ['priority' => -1000]);
+
+    if (class_exists(DocBlockFactory::class)) {
+        $services->set('api_platform.property_info.php_doc_extractor', PhpDocExtractor::class)
+            ->tag('property_info.description_extractor', ['priority' => -1000])
+            ->tag('property_info.type_extractor', ['priority' => -1001])
+            ->tag('property_info.constructor_extractor', ['priority' => -1001]);
+    }
+
+    if (class_exists(PhpDocParser::class) && class_exists(ContextFactory::class)) {
+        $services->set('api_platform.property_info.phpstan_extractor', PhpStanExtractor::class)
+            ->tag('property_info.type_extractor', ['priority' => -1000])
+            ->tag('property_info.constructor_extractor', ['priority' => -1000]);
+    }
+
+    $services->set('api_platform.property_info.constructor_extractor', ConstructorExtractor::class)
+        ->args([tagged_iterator('property_info.constructor_extractor')])
+        ->tag('property_info.type_extractor', ['priority' => -999]);
+
     $services->set('api_platform.property_info', PropertyInfoExtractor::class)
         ->args([
             tagged_iterator('property_info.list_extractor'),
@@ -78,6 +109,13 @@
             tagged_iterator('property_info.initializable_extractor'),
         ]);
 
+    $services->set('api_platform.property_info.cache', PropertyInfoCacheExtractor::class)
+        ->decorate('api_platform.property_info')
+        ->args([
+            service('.inner'),
+            service('cache.property_info'),
+        ]);
+
     $services->set('api_platform.negotiator', Negotiator::class);
 
     $services->set('api_platform.resource_class_resolver', ResourceClassResolver::class)

src/Symfony/Bundle/Resources/config/api.php

@@ -190,6 +190,7 @@ public function testCommonConfiguration(): void
             'api_platform.path_segment_name_generator.dash',
             'api_platform.path_segment_name_generator.underscore',
             'api_platform.metadata.inflector',
+            'api_platform.property_info',
             'api_platform.resource_class_resolver',
             'api_platform.route_loader',
             'api_platform.router',
@@ -231,7 +232,6 @@ public function testCommonConfiguration(): void
             'api_platform.iri_converter',
             'api_platform.path_segment_name_generator',
             'api_platform.property_accessor',
-            'api_platform.property_info',
             'api_platform.serializer',
             'api_platform.inflector',
         ];

src/Symfony/Tests/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -25,7 +25,6 @@
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\JsonStreamerTransformerPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\MetadataAwareNameConverterPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\MutatorPass;
-use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\PropertyInfoPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\SerializerMappingLoaderPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\TestClientPass;
 use ApiPlatform\Symfony\Bundle\DependencyInjection\Compiler\TestMercureHubPass;
@@ -58,7 +57,6 @@ public function testBuild(): void
         $this->assertContains(TestClientPass::class, $passClasses);
         $this->assertContains(TestMercureHubPass::class, $passClasses);
         $this->assertContains(AuthenticatorManagerPass::class, $passClasses);
-        $this->assertContains(PropertyInfoPass::class, $passClasses);
         $this->assertContains(SerializerMappingLoaderPass::class, $passClasses);
         $this->assertContains(MutatorPass::class, $passClasses);
         $this->assertContains(JsonStreamerTransformerPass::class, $passClasses);