Throw exception if parameter property does not match class property name

Author: Maxcastel

src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php

@@ -487,6 +487,8 @@ private function createParametersFromAttributes(Operation $operation): Parameter
 
                 if (null === $parameter->getProperty()) {
                     $parameter = $parameter->withProperty($reflectionProperty->getName());
+                } elseif ($parameter->getProperty() !== $reflectionProperty->getName()) {
+                    throw new RuntimeException(\sprintf('Parameter attribute on property "%s" must target itself or have no explicit property. Got "property: \'%s\'" instead.', $reflectionProperty->getName(), $parameter->getProperty()));
                 }
 
                 $parameters->add($key, $parameter);

src/Metadata/Tests/Resource/Factory/ParameterResourceMetadataCollectionFactoryTest.php

@@ -15,6 +15,7 @@
 
 use ApiPlatform\Metadata\ApiProperty;
 use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Exception\RuntimeException;
 use ApiPlatform\Metadata\FilterInterface;
 use ApiPlatform\Metadata\GetCollection;
 use ApiPlatform\Metadata\Parameters;
@@ -282,6 +283,32 @@ public function testParameterFactoryWithLimitedProperties(): void
         $this->assertSame(['name'], $param->getProperties());
     }
 
+    public function testQueryParameterFromPropertyAttributeThrowsExceptionWhenPropertyMismatch(): void
+    {
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Parameter attribute on property "name" must target itself or have no explicit property. Got "property: \'description\'" instead.');
+
+        $nameCollection = $this->createStub(PropertyNameCollectionFactoryInterface::class);
+        $nameCollection->method('create')->willReturn(new PropertyNameCollection(['id', 'name', 'description']));
+
+        $propertyMetadata = $this->createStub(PropertyMetadataFactoryInterface::class);
+        $propertyMetadata->method('create')->willReturn(
+            new ApiProperty(readable: true),
+        );
+
+        $filterLocator = $this->createStub(ContainerInterface::class);
+        $filterLocator->method('has')->willReturn(false);
+
+        $parameterFactory = new ParameterResourceMetadataCollectionFactory(
+            $nameCollection,
+            $propertyMetadata,
+            new AttributesResourceMetadataCollectionFactory(),
+            $filterLocator
+        );
+
+        $parameterFactory->create(ParameterOnPropertiesMismatchException::class);
+    }
+
     public function testNestedPropertyWithNameConverter(): void
     {
         $nameCollection = $this->createStub(PropertyNameCollectionFactoryInterface::class);
@@ -537,3 +564,12 @@ class NestedTestVariation
     public ?int $id = null;
     public ?string $variantName = null;
 }
+
+#[ApiResource]
+class ParameterOnPropertiesMismatchException
+{
+    #[QueryParameter(key: 'search', property: 'description')]
+    public string $name = '';
+
+    public string $description = '';
+}