Skip to content

fix(symfony): security regression when ResourceAccessChecker is decorated (#7896) #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giosh94mhz wants to merge 2 commits into
base: 4.3
Choose a base branch
from
+51 −1
Open

fix(symfony): security regression when ResourceAccessChecker is decorated (#7896) #7897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e709bb
fix(symfony): security regression when ResourceAccessChecker is decor…
giosh94mhz Mar 31, 2026
e6493c2
test
soyuka Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Symfony/Security/State/AccessCheckerProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,14 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
];
}

if ('pre_read' === $this->event && $this->resourceAccessChecker instanceof ObjectVariableCheckerInterface && $this->resourceAccessChecker->usesObjectVariable($isGranted, $resourceAccessCheckerContext)) {
// Skip pre_read optimization when object is used via granted (or usage is not predicatable)
if (
'pre_read' === $this->event
&& (
!$this->resourceAccessChecker instanceof ObjectVariableCheckerInterface
|| $this->resourceAccessChecker->usesObjectVariable($isGranted, $resourceAccessCheckerContext)
)
) {
return $this->decorated->provide($operation, $uriVariables, $context);
}

Expand Down
43 changes: 43 additions & 0 deletions tests/Symfony/Security/State/AccessCheckerProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use ApiPlatform\Metadata\ResourceAccessCheckerInterface;
use ApiPlatform\State\ProviderInterface;
use ApiPlatform\Symfony\Security\Exception\AccessDeniedException;
use ApiPlatform\Symfony\Security\ObjectVariableCheckerInterface;
use ApiPlatform\Symfony\Security\State\AccessCheckerProvider;
use ApiPlatform\Tests\Fixtures\DummyEntity;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -61,6 +62,44 @@ public function testCheckAccessWithEventPostValidate(): void
$accessChecker->provide($operation, [], []);
}

public function testPreReadSkipsSecurityWhenResourceAccessCheckerIsDecorated(): void
{
$obj = new \stdClass();
$operation = new Get(class: DummyEntity::class, security: 'is_granted("ROLE_ADMIN")');
$decorated = $this->createMock(ProviderInterface::class);
$decorated->expects($this->once())->method('provide')->willReturn($obj);
$resourceAccessChecker = $this->createMock(ResourceAccessCheckerInterface::class);
$resourceAccessChecker->expects($this->never())->method('isGranted');
$accessChecker = new AccessCheckerProvider($decorated, $resourceAccessChecker, 'pre_read');
$this->assertSame($obj, $accessChecker->provide($operation, [], []));
}

public function testPreReadChecksSecurityWhenObjectVariableIsNotUsed(): void
{
$obj = new \stdClass();
$operation = new Get(class: DummyEntity::class, security: 'is_granted("ROLE_ADMIN")');
$decorated = $this->createMock(ProviderInterface::class);
$decorated->expects($this->once())->method('provide')->willReturn($obj);
$resourceAccessChecker = $this->createMock(ResourceAccessCheckerWithObjectVariableInterface::class);
$resourceAccessChecker->method('usesObjectVariable')->willReturn(false);
$resourceAccessChecker->expects($this->once())->method('isGranted')->with(DummyEntity::class, 'is_granted("ROLE_ADMIN")', ['object' => null, 'previous_object' => null, 'request' => null])->willReturn(true);
$accessChecker = new AccessCheckerProvider($decorated, $resourceAccessChecker, 'pre_read');
$this->assertSame($obj, $accessChecker->provide($operation, [], []));
}

public function testPreReadSkipsSecurityWhenObjectVariableIsUsed(): void
{
$obj = new \stdClass();
$operation = new Get(class: DummyEntity::class, security: 'is_granted("ROLE_ADMIN") and object.owner == user');
$decorated = $this->createMock(ProviderInterface::class);
$decorated->expects($this->once())->method('provide')->willReturn($obj);
$resourceAccessChecker = $this->createMock(ResourceAccessCheckerWithObjectVariableInterface::class);
$resourceAccessChecker->method('usesObjectVariable')->willReturn(true);
$resourceAccessChecker->expects($this->never())->method('isGranted');
$accessChecker = new AccessCheckerProvider($decorated, $resourceAccessChecker, 'pre_read');
$this->assertSame($obj, $accessChecker->provide($operation, [], []));
}

public function testCheckAccessDenied(): void
{
$this->expectException(AccessDeniedException::class);
Expand Down Expand Up @@ -91,3 +130,7 @@ public function testCheckAccessDeniedWithGraphQl(): void
$accessChecker->provide($operation, [], []);
}
}

interface ResourceAccessCheckerWithObjectVariableInterface extends ResourceAccessCheckerInterface, ObjectVariableCheckerInterface
{
}
Loading