Skip to content

feat: test placeholder for speaker images #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ginifizz merged 1 commit into from
May 14, 2025
Merged

feat: test placeholder for speaker images #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pwa/app/(con)/[locale]/con/[edition]/conferences/[slug]/components/ConferenceSpeaker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ const ConferenceSpeaker = ({ conference }: SpeakerProps) => {
)}
>
{conference.edition === "2025" ? (
<SpeakerImage2025 speaker={speaker} image={image} />
<SpeakerImage2025
speaker={speaker}
image={image}
placeholder={placeholder}
/>
) : (
<SpeakerImage image={image} placeholder={placeholder} />
)}
Expand Down
7 changes: 6 additions & 1 deletion pwa/app/(con)/[locale]/con/[edition]/speakers/[slug]/SpeakerPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ export default function SpeakerPageTemplate({
<div className="flex flex-col relative flex-wrap items-center bg-grey px-10 pb-10 pt-28 | lg:flex-row lg:items-start | sm:pb-20">
<div className="w-72 h-72 | md:w-80 md:h-80 | lg:w-[400px] lg:h-[400px]">
{edition === "2025" ? (
<SpeakerImage2025 speaker={speakerData} big image={image} />
<SpeakerImage2025
speaker={speakerData}
big
image={image}
placeholder={placeholder}
/>
) : (
<SpeakerImage big image={image} placeholder={placeholder} />
)}
Expand Down
11 changes: 8 additions & 3 deletions pwa/components/con/speakers/SpeakerImage2025.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ export default function SpeakerImage({
big = false,
hoverable = true,
speaker,
placeholder,
}: SpeakerImageProps) {
if (speaker.edition === "2025") {
const { name } = speaker;
const { name, } = speaker;
const angle = nameToAngle(name);
const size = nameToSize(name);
const pos = cssPositionOnCircle(angle);
Expand Down Expand Up @@ -100,8 +101,12 @@ export default function SpeakerImage({
)}
alt=""
fill
sizes={big ? "(max-width: 768px) 400px, 800px" : "400px"}
loading="lazy"
sizes={big ? "(max-width: 768px) 350px, 600px" : "350px"}
placeholder={
placeholder
? (placeholder as `data:image/${string}`)
: undefined
}
/>
</div>
<div
Expand Down
Binary file modified pwa/public/images/con/2025/partners/mongo-db.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions pwa/utils/getPlaceholder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ export const getPlaceholder = cache(async (imagePath: string) => {
try {
// Redimensionner l'image à une taille très petite
const resizedImageBuffer = await sharp(imagePath)
.resize(50, 50)
.jpeg({ mozjpeg: true, quality: 50 })
.resize(20, 20)
.png({ quality: 70 })
.toBuffer();

// Convertir l'image redimensionnée en base64
const base64Placeholder = resizedImageBuffer.toString("base64");
return `data:image/jpeg;base64,${base64Placeholder}`;
return `data:image/png;base64,${base64Placeholder}`;
} catch (error) {
console.error("The placeholder can't be generated: ", error);
throw error;
Expand Down
Loading