Skip to content

Commit 134e77e

Browse files
AlinsRanCopilot
andcommitted
fix: use PUT method for ADC server /validate endpoint
The ADC server registers PUT /validate (not POST), matching the same HTTP method used for PUT /sync. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent d95462e commit 134e77e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

internal/adc/client/executor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ func (e *HTTPADCExecutor) runHTTPValidateForSingleServer(ctx context.Context, se
252252
return fmt.Errorf("failed to load resources from file %s: %w", filePath, err)
253253
}
254254

255-
req, err := e.buildHTTPRequest(ctx, serverAddr, config, labels, types, resources, http.MethodPost, "/validate")
255+
req, err := e.buildHTTPRequest(ctx, serverAddr, config, labels, types, resources, http.MethodPut, "/validate")
256256
if err != nil {
257257
return fmt.Errorf("failed to build validate request: %w", err)
258258
}

internal/webhook/v1/adc_validation_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,6 @@ func managedIngressClassWithGatewayProxyMode(endpoint, mode string) []runtime.Ob
8686

8787
func requireValidateRequest(t *testing.T, r *http.Request) {
8888
t.Helper()
89-
require.Equal(t, http.MethodPost, r.Method)
89+
require.Equal(t, http.MethodPut, r.Method)
9090
require.Equal(t, "/validate", r.URL.Path)
9191
}

0 commit comments

Comments
 (0)