fix: remove duplicate failurePolicy in webhook markers; fix ApisixConsumer skip logic

- Remove redundant failurePolicy=fail from all 4 webhook marker lines,
  keeping only failurePolicy=Ignore (kubebuilder uses the last occurrence,
  having both was ambiguous and wrong)
- Fix ApisixConsumer ValidateCreate/ValidateUpdate: remove the unnecessary
  len(warnings) > 0 guard that skipped ADC validation when secrets were
  missing. Unlike ApisixTls, missing secretRef in ApisixConsumer merely
  skips that credential in translation; the consumer can still be validated
  by ADC. Only skip when initErr is non-nil (ADC client init failed).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: AlinsRan

internal/webhook/v1/apisixconsumer_webhook.go

@@ -42,7 +42,7 @@ func SetupApisixConsumerWebhookWithManager(mgr ctrl.Manager) error {
 		Complete()
 }
 
-// +kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixconsumer,mutating=false,failurePolicy=fail,sideEffects=None,groups=apisix.apache.org,resources=apisixconsumers,verbs=create;update,versions=v2,name=vapisixconsumer-v2.kb.io,admissionReviewVersions=v1,failurePolicy=Ignore
+// +kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixconsumer,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=apisix.apache.org,resources=apisixconsumers,verbs=create;update,versions=v2,name=vapisixconsumer-v2.kb.io,admissionReviewVersions=v1
 
 type ApisixConsumerCustomValidator struct {
 	Client       client.Client
@@ -75,7 +75,8 @@ func (v *ApisixConsumerCustomValidator) ValidateCreate(ctx context.Context, obj
 	}
 
 	warnings := v.collectWarnings(ctx, consumer)
-	if v.initErr != nil || len(warnings) > 0 {
+	if v.initErr != nil {
+		apisixConsumerLog.Error(v.initErr, "ADC validator init failed, skipping ADC validation")
 		return warnings, nil
 	}
 	return warnings, v.adcValidator.Validate(ctx, consumer)
@@ -92,7 +93,8 @@ func (v *ApisixConsumerCustomValidator) ValidateUpdate(ctx context.Context, oldO
 	}
 
 	warnings := v.collectWarnings(ctx, consumer)
-	if v.initErr != nil || len(warnings) > 0 {
+	if v.initErr != nil {
+		apisixConsumerLog.Error(v.initErr, "ADC validator init failed, skipping ADC validation")
 		return warnings, nil
 	}
 	return warnings, v.adcValidator.Validate(ctx, consumer)

internal/webhook/v1/apisixroute_webhook.go

@@ -41,7 +41,7 @@ func SetupApisixRouteWebhookWithManager(mgr ctrl.Manager) error {
 		Complete()
 }
 
-// +kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixroute,mutating=false,failurePolicy=fail,sideEffects=None,groups=apisix.apache.org,resources=apisixroutes,verbs=create;update,versions=v2,name=vapisixroute-v2.kb.io,admissionReviewVersions=v1,failurePolicy=Ignore
+// +kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixroute,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=apisix.apache.org,resources=apisixroutes,verbs=create;update,versions=v2,name=vapisixroute-v2.kb.io,admissionReviewVersions=v1
 
 type ApisixRouteCustomValidator struct {
 	Client       client.Client

internal/webhook/v1/apisixtls_webhook.go

@@ -42,7 +42,7 @@ func SetupApisixTlsWebhookWithManager(mgr ctrl.Manager) error {
 		Complete()
 }
 
-// +kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixtls,mutating=false,failurePolicy=fail,sideEffects=None,groups=apisix.apache.org,resources=apisixtlses,verbs=create;update,versions=v2,name=vapisixtls-v2.kb.io,admissionReviewVersions=v1,failurePolicy=Ignore
+// +kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixtls,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=apisix.apache.org,resources=apisixtlses,verbs=create;update,versions=v2,name=vapisixtls-v2.kb.io,admissionReviewVersions=v1
 
 type ApisixTlsCustomValidator struct {
 	Client       client.Client

internal/webhook/v1/consumer_webhook.go

@@ -45,7 +45,7 @@ func SetupConsumerWebhookWithManager(mgr ctrl.Manager) error {
 		Complete()
 }
 
-// +kubebuilder:webhook:path=/validate-apisix-apache-org-v1alpha1-consumer,mutating=false,failurePolicy=fail,sideEffects=None,groups=apisix.apache.org,resources=consumers,verbs=create;update,versions=v1alpha1,name=vconsumer-v1alpha1.kb.io,admissionReviewVersions=v1,failurePolicy=Ignore
+// +kubebuilder:webhook:path=/validate-apisix-apache-org-v1alpha1-consumer,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=apisix.apache.org,resources=consumers,verbs=create;update,versions=v1alpha1,name=vconsumer-v1alpha1.kb.io,admissionReviewVersions=v1
 
 type ConsumerCustomValidator struct {
 	Client       client.Client