@@ -30,7 +30,6 @@ import (
3030 "github.com/apache/apisix-ingress-controller/api/v1alpha1"
3131 apiv2 "github.com/apache/apisix-ingress-controller/api/v2"
3232 "github.com/apache/apisix-ingress-controller/internal/controller/status"
33- "github.com/apache/apisix-ingress-controller/internal/provider"
3433 "github.com/apache/apisix-ingress-controller/internal/utils"
3534)
3635
@@ -46,11 +45,7 @@ type ApisixPluginConfigReconciler struct {
4645func (r * ApisixPluginConfigReconciler ) SetupWithManager (mgr ctrl.Manager ) error {
4746 return ctrl .NewControllerManagedBy (mgr ).
4847 For (& apiv2.ApisixPluginConfig {}).
49- WithEventFilter (
50- predicate .Or (
51- predicate.GenerationChangedPredicate {},
52- ),
53- ).
48+ WithEventFilter (predicate.GenerationChangedPredicate {}).
5449 Watches (& networkingv1.IngressClass {},
5550 handler .EnqueueRequestsFromMapFunc (r .listApisixPluginConfigForIngressClass ),
5651 builder .WithPredicates (
@@ -67,23 +62,12 @@ func (r *ApisixPluginConfigReconciler) SetupWithManager(mgr ctrl.Manager) error
6762func (r * ApisixPluginConfigReconciler ) Reconcile (ctx context.Context , req ctrl.Request ) (ctrl.Result , error ) {
6863 var pc apiv2.ApisixPluginConfig
6964 if err := r .Get (ctx , req .NamespacedName , & pc ); err != nil {
70- if client .IgnoreNotFound (err ) == nil {
71- pc .Namespace = req .Namespace
72- pc .Name = req .Name
73- pc .TypeMeta = metav1.TypeMeta {
74- Kind : KindApisixPluginConfig ,
75- APIVersion : apiv2 .GroupVersion .String (),
76- }
77-
78- return ctrl.Result {}, nil
79- }
80- return ctrl.Result {}, err
65+ return ctrl.Result {}, client .IgnoreNotFound (err )
8166 }
8267
8368 var (
84- tctx = provider .NewDefaultTranslateContext (ctx )
85- ic * networkingv1.IngressClass
86- err error
69+ ic * networkingv1.IngressClass
70+ err error
8771 )
8872 defer func () {
8973 r .updateStatus (& pc , err )
@@ -92,7 +76,7 @@ func (r *ApisixPluginConfigReconciler) Reconcile(ctx context.Context, req ctrl.R
9276 if ic , err = r .getIngressClass (& pc ); err != nil {
9377 return ctrl.Result {}, err
9478 }
95- if err = r .processIngressClassParameters (ctx , tctx , & pc , ic ); err != nil {
79+ if err = r .processIngressClassParameters (ctx , & pc , ic ); err != nil {
9680 return ctrl.Result {}, err
9781 }
9882 return ctrl.Result {}, nil
@@ -174,15 +158,13 @@ func (r *ApisixPluginConfigReconciler) getDefaultIngressClass() (*networkingv1.I
174158}
175159
176160// processIngressClassParameters processes the IngressClass parameters that reference GatewayProxy
177- func (r * ApisixPluginConfigReconciler ) processIngressClassParameters (ctx context.Context , tc * provider. TranslateContext , pc * apiv2.ApisixPluginConfig , ingressClass * networkingv1.IngressClass ) error {
161+ func (r * ApisixPluginConfigReconciler ) processIngressClassParameters (ctx context.Context , pc * apiv2.ApisixPluginConfig , ingressClass * networkingv1.IngressClass ) error {
178162 if ingressClass == nil || ingressClass .Spec .Parameters == nil {
179163 return nil
180164 }
181165
182166 var (
183- ingressClassKind = utils .NamespacedNameKind (ingressClass )
184- pcKind = utils .NamespacedNameKind (pc )
185- parameters = ingressClass .Spec .Parameters
167+ parameters = ingressClass .Spec .Parameters
186168 )
187169 if parameters .APIGroup == nil || * parameters .APIGroup != v1alpha1 .GroupVersion .Group || parameters .Kind != KindGatewayProxy {
188170 return nil
@@ -197,15 +179,7 @@ func (r *ApisixPluginConfigReconciler) processIngressClassParameters(ctx context
197179 ns = & pc .Namespace
198180 }
199181
200- if err := r .Get (ctx , client.ObjectKey {Namespace : * ns , Name : parameters .Name }, & gatewayProxy ); err != nil {
201- r .Log .Error (err , "failed to get GatewayProxy" , "namespace" , * ns , "name" , parameters .Name )
202- return err
203- }
204-
205- tc .GatewayProxies [ingressClassKind ] = gatewayProxy
206- tc .ResourceParentRefs [pcKind ] = append (tc .ResourceParentRefs [pcKind ], ingressClassKind )
207-
208- return nil
182+ return r .Get (ctx , client.ObjectKey {Namespace : * ns , Name : parameters .Name }, & gatewayProxy )
209183}
210184
211185func (r * ApisixPluginConfigReconciler ) updateStatus (pc * apiv2.ApisixPluginConfig , err error ) {
0 commit comments