fix: ignore dangling label args

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: AlinsRan

internal/controller/label/label.go

@@ -44,7 +44,7 @@ func GenLabel(obj client.Object, args ...string) Label {
 	label[LabelControllerName] = config.ControllerConfig.ControllerName
 	label[LabelManagedBy] = "apisix-ingress-controller"
 	label[LabelResourceKey] = fmt.Sprintf("%s/%s/%s", label[LabelKind], label[LabelNamespace], label[LabelName])
-	for i := 0; i < len(args); i += 2 {
+	for i := 0; i+1 < len(args); i += 2 {
 		label[args[i]] = args[i+1]
 	}
 	return label

internal/controller/label/label_test.go

@@ -56,3 +56,21 @@ func TestGenLabelWithObjectLabels(t *testing.T) {
 	require.Equal(t, "apisix-ingress-controller", labels[LabelManagedBy])
 	require.Equal(t, "ApisixConsumer/default/demo", labels[LabelResourceKey])
 }
+
+func TestGenLabel_IgnoresDanglingKeyArg(t *testing.T) {
+	consumer := &apiv2.ApisixConsumer{
+		TypeMeta: metav1.TypeMeta{
+			Kind:       "ApisixConsumer",
+			APIVersion: apiv2.GroupVersion.String(),
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "demo",
+			Namespace: "default",
+		},
+	}
+
+	labels := GenLabel(consumer, "team", "payments", "dangling")
+
+	require.Equal(t, "payments", labels["team"])
+	require.NotContains(t, labels, "dangling")
+}