fix

Author: AlinsRan

internal/controller/httproute_controller.go

@@ -155,7 +155,7 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	if err := r.Get(ctx, req.NamespacedName, hr); err != nil {
 		if client.IgnoreNotFound(err) == nil {
 			if err := r.updateHTTPRoutePolicyStatusOnDeleting(ctx, req.NamespacedName); err != nil {
-				return ctrl.Result{}, err
+				r.Log.Error(err, "failed to update HTTPRoutePolicy status on HTTPRoute deleting", "httproute", req.NamespacedName)
 			}
 			hr.Namespace = req.Namespace
 			hr.Name = req.Name

internal/controller/httproutepolicy.go

@@ -45,8 +45,7 @@ func (r *HTTPRouteReconciler) processHTTPRoutePolicies(tctx *provider.TranslateC
 		key  = indexer.GenIndexKeyWithGK(gatewayv1.GroupName, internaltypes.KindHTTPRoute, httpRoute.GetNamespace(), httpRoute.GetName())
 	)
 	if err := r.List(context.Background(), &list, client.MatchingFields{indexer.PolicyTargetRefs: key}); err != nil {
-		r.Log.Error(err, "failed to list HTTPRoutePolicies for HTTPRoute", "httproute", utils.NamespacedName(httpRoute))
-		return nil
+		return err
 	}
 
 	if len(list.Items) == 0 {
@@ -110,8 +109,7 @@ func (r *HTTPRouteReconciler) updateHTTPRoutePolicyStatusOnDeleting(ctx context.
 		key  = indexer.GenIndexKeyWithGK(gatewayv1.GroupName, internaltypes.KindHTTPRoute, nn.Namespace, nn.Name)
 	)
 	if err := r.List(ctx, &list, client.MatchingFields{indexer.PolicyTargetRefs: key}); err != nil {
-		r.Log.Error(err, "failed to list HTTPRoutePolicies for HTTPRoute", "httproute", nn)
-		return nil
+		return err
 	}
 	var (
 		httpRoutes = make(map[types.NamespacedName]gatewayv1.HTTPRoute)
@@ -143,8 +141,7 @@ func (r *IngressReconciler) processHTTPRoutePolicies(tctx *provider.TranslateCon
 		key  = indexer.GenIndexKeyWithGK(networkingv1.GroupName, internaltypes.KindIngress, ingress.GetNamespace(), ingress.GetName())
 	)
 	if err := r.List(context.Background(), &list, client.MatchingFields{indexer.PolicyTargetRefs: key}); err != nil {
-		r.Log.Error(err, "failed to list HTTPRoutePolicies for Ingress", "ingress", utils.NamespacedName(ingress))
-		return nil
+		return err
 	}
 
 	if len(list.Items) == 0 {
@@ -186,8 +183,7 @@ func (r *IngressReconciler) updateHTTPRoutePolicyStatusOnDeleting(ctx context.Co
 		key  = indexer.GenIndexKeyWithGK(networkingv1.GroupName, internaltypes.KindIngress, nn.Namespace, nn.Name)
 	)
 	if err := r.List(ctx, &list, client.MatchingFields{indexer.PolicyTargetRefs: key}); err != nil {
-		r.Log.Error(err, "failed to list HTTPRoutePolicies for Ingress", "ingress", nn)
-		return nil
+		return err
 	}
 	var (
 		ingress2ParentRef = make(map[types.NamespacedName]gatewayv1.ParentReference)

internal/controller/ingress_controller.go

@@ -143,7 +143,7 @@ func (r *IngressReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 	if err := r.Get(ctx, req.NamespacedName, ingress); err != nil {
 		if client.IgnoreNotFound(err) == nil {
 			if err := r.updateHTTPRoutePolicyStatusOnDeleting(ctx, req.NamespacedName); err != nil {
-				return ctrl.Result{}, err
+				r.Log.Error(err, "failed to update HTTPRoutePolicy status on Ingress deleting", "ingress", req.NamespacedName)
 			}
 
 			// Ingress was deleted, clean up corresponding resources
@@ -212,7 +212,6 @@ func (r *IngressReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 	// process HTTPRoutePolicy
 	if err := r.processHTTPRoutePolicies(tctx, ingress); err != nil {
 		r.Log.Error(err, "failed to process HTTPRoutePolicy", "ingress", ingress.Name)
-		return ctrl.Result{}, err
 	}
 
 	ProcessBackendTrafficPolicy(r.Client, r.Log, tctx)