feat: support sync when update gateway proxy#109
Merged
ronething merged 6 commits intoApr 25, 2025
Conversation
Signed-off-by: ashing <axingfly@gmail.com>
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-04-24T18:17:45Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: API7
project: api7-ingress-controller
url: https://github.com/api7/api7-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- GatewayInvalidTLSConfiguration
- GatewaySecretInvalidReferenceGrant
- GatewaySecretMissingReferenceGrant
- GatewaySecretReferenceGrantAllInNamespace
- GatewaySecretReferenceGrantSpecific
- HTTPRouteExactPathMatching
- HTTPRouteHTTPSListener
- HTTPRouteHeaderMatching
- HTTPRouteHostnameIntersection
- HTTPRouteInvalidBackendRefUnknownKind
- HTTPRouteInvalidCrossNamespaceBackendRef
- HTTPRouteInvalidCrossNamespaceParentRef
- HTTPRouteInvalidNonExistentBackendRef
- HTTPRouteInvalidParentRefNotMatchingSectionName
- HTTPRouteInvalidReferenceGrant
- HTTPRouteListenerHostnameMatching
- HTTPRouteMatching
- HTTPRouteMatchingAcrossRoutes
- HTTPRoutePartiallyInvalidViaInvalidReferenceGrant
- HTTPRouteReferenceGrant
- HTTPRouteRequestHeaderModifier
- HTTPRouteWeight
statistics:
Failed: 0
Passed: 11
Skipped: 22
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 22 test skips. |
Signed-off-by: ashing <axingfly@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for syncing resources when the GatewayProxy is updated by adjusting leader election settings, adding mutex locks to ADC execution, and updating various e2e tests to verify the changes.
- Updated e2e tests for Ingress, HTTPRoute, and Consumer to validate sync behavior after updating the GatewayProxy.
- Modified the ADC provider by introducing an execLock and refactoring the handling of ADC configuration values.
- Updated controller watchers and indexers to include GatewayProxy changes and improved leader election configuration.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/ingress/ingress.go | Updated externalName test and added new GatewayProxy sync test. |
| test/e2e/gatewayapi/httproute.go | Updated externalName test and added new HTTPRoute sync test. |
| test/e2e/framework/dashboard.go | Added an empty payload for GetDataplaneCertificates request. |
| test/e2e/crds/consumer.go | Added a consumer sync test case for GatewayProxy updates. |
| internal/provider/adc/adc.go | Introduced mutex execLock and refactored ADC config handling. |
| internal/controller/ingress_controller.go | Added GatewayProxy watch and simplified ingress class check. |
| internal/controller/indexer/indexer.go | Added index creation for IngressClassParametersRef. |
| internal/controller/httproute_controller.go | Added GatewayProxy watch for HTTPRoute reconciliation. |
| internal/controller/consumer_controller.go | Added GatewayProxy watch for Consumer reconciliation. |
| internal/controller/config/* | Updated leader election field names and durations. |
| config/samples/config.yaml | Updated leader election configuration sample values. |
Files not reviewed (1)
- Makefile: Language not supported
AlinsRan
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adcExecto prevent unforeseen issues caused by parallel execution of adcref: https://apiseven.feishu.cn/docx/E5EgdlVTAodihcxexUxcEqd3nhe#share-Vo3gdxfiXoyPXwx48k7cYwKgnHc