fix: Set parent namespace in HTTPRoutePolicy and refactor related tests#152
Merged
dspo merged 3 commits intoMay 30, 2025
Merged
Conversation
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-05-30T07:47:12Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
AlinsRan
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
在原来的实现中,当
HTTPRoute.spec.prentRefs[]中省略 namespace 时,HTTPRoutePolicy.status.ancestors[].ancestorRef 中的 namespace 也会被省略。而 ancestorRef 中 namespace 不应当被省略。这个 PR 修复这个问题。另外在测试中更新了 HTTPRoute HTTPRoutePolicy 的 apply 方法和状态断言,使创建 HTTPRoute 和 HTTPRoutePolicy 更简单,断言更准确(而不是靠 ContainsSubstring 来判断状态)。
Pre-submission checklist: