chore: remove some comment about dashboard#174
Merged
Conversation
Signed-off-by: ashing <axingfly@gmail.com>
AlinsRan
approved these changes
Jun 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Clean up dashboard-related comments and consolidate test certificate fixtures across e2e tests.
- Simplify error assertion message when listing SSL resources
- Move embedded test certificate and key into a single constants file (
apisix_consts.go) and remove duplication inapi7_consts.go - Refine comments in ADC translator regarding wildcard hostnames and SSL object ID generation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/gatewayapi/gateway.go | Simplified the error message context for SSL listing |
| test/e2e/framework/apisix_consts.go | Added embedded test server certificate and key constants |
| test/e2e/framework/api7_consts.go | Removed duplicated embedded test certificate and key |
| internal/provider/adc/translator/gateway.go | Updated comments about wildcard hostnames and duplicate SSL IDs |
Comments suppressed due to low confidence (2)
internal/provider/adc/translator/gateway.go:119
- [nitpick] Clarify this comment to specify that you're using the certificate fingerprint or a unique hash as the SSL object ID, e.g.: 'Use certificate fingerprint as the SSL object ID to prevent duplicates.'
// Note: use cert as id to avoid duplicate certificate across ssl objects
test/e2e/gatewayapi/gateway.go:289
- [nitpick] Provide a more descriptive error message context, for example: 'list SSL resources from dataplane', to make test failures easier to diagnose.
Expect(err).NotTo(HaveOccurred(), "list ssl")
| Key: string(key), | ||
| }) | ||
| // Dashboard doesn't allow wildcard hostname | ||
| // we doesn't allow wildcard hostname |
There was a problem hiding this comment.
Fix grammatical error in comment: change 'we doesn't allow wildcard hostname' to 'we don't allow wildcard hostnames' or 'wildcard hostnames are not allowed'.
Suggested change
| // we doesn't allow wildcard hostname | |
| // wildcard hostnames are not allowed |
| TestServerKey string | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
[nitpick] Embedding large PEM blocks inline can reduce readability; consider loading these certificate fixtures from external files or a shared test helper.
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-06-23T06:19:40Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
Contributor
conformance test reportapiVersion: gateway.networking.k8s.io/v1
date: "2025-06-23T06:20:54Z"
gatewayAPIChannel: standard
gatewayAPIVersion: v1.2.0
implementation:
contact: null
organization: APISIX
project: apisix-ingress-controller
url: https://github.com/apache/apisix-ingress-controller.git
version: v2.0.0
kind: ConformanceReport
mode: default
profiles:
- core:
result: partial
skippedTests:
- HTTPRouteHTTPSListener
statistics:
Failed: 0
Passed: 32
Skipped: 1
name: GATEWAY-HTTP
summary: Core tests partially succeeded with 1 test skips. |
dspo
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: