feat: Update HTTPRoutePolicy handling for Ingress#99
Merged
Conversation
Refactor the HTTPRoutePolicy update function to handle Ingress objects and improve logging. Add functionality to process HTTPRoutePolicies for Ingress in the IngressReconciler. Update tests to include scenarios for HTTPRoutePolicy targeting Ingress.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors HTTPRoutePolicy handling for Ingress by updating the update function, adding corresponding tests, and enhancing logging.
- Refactored resource translation and policy processing for Ingress.
- Added E2E tests for HTTPRoutePolicy targeting Ingress.
- Updated indexers and controller event handling to support the new Ingress policy workflow.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/ingress/ingress.go | Added comprehensive E2E tests for HTTPRoutePolicy handling on Ingress. |
| internal/provider/adc/translator/ingress.go | Updated Ingress translation to integrate HTTPRoutePolicy processing. |
| internal/provider/adc/translator/httproute.go | Refactored HTTPRoutePolicy functions to separate Ingress and HTTPRoute paths. |
| internal/controller/ingress_controller.go | Introduced generic event handling and Ingress-specific HTTPRoutePolicy logic. |
| internal/controller/indexer/indexer.go | Added a new index for HTTPRoutePolicy targetRefs on Ingress. |
| internal/controller/httproutepolicy.go | Added policy processing for Ingress and refactored conflict handling. |
| internal/controller/httproute_controller.go | Updated event predicates and object key fetching in HTTPRoute reconciliation. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AlinsRan
reviewed
Apr 21, 2025
AlinsRan
reviewed
Apr 21, 2025
AlinsRan
reviewed
Apr 21, 2025
AlinsRan
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the HTTPRoutePolicy update function to handle Ingress objects and improve logging. Add functionality to process HTTPRoutePolicies for Ingress in the IngressReconciler. Update tests to include scenarios for HTTPRoutePolicy targeting Ingress.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: