Skip to content

feat: release v0.9.12#102

Merged
nic-6443 merged 1 commit intomasterfrom
nic/release-v0.9.12
Apr 27, 2026
Merged

feat: release v0.9.12#102
nic-6443 merged 1 commit intomasterfrom
nic/release-v0.9.12

Conversation

@jarvis9443
Copy link
Copy Markdown
Contributor

@jarvis9443 jarvis9443 commented Apr 27, 2026

Signed-off-by: Jarvis jarvis@api7.ai

Summary by CodeRabbit

  • Chores
    • Added LuaRocks package specification for jsonschema v0.9.12-0, enabling distribution and installation via LuaRocks package manager with JSON Schema draft support and required dependencies.

Signed-off-by: Jarvis <jarvis@api7.ai>
Copilot AI review requested due to automatic review settings April 27, 2026 01:51
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

📝 Walkthrough

Walkthrough

Adds a new LuaRocks rockspec file for jsonschema version 0.9.12-0, defining package metadata, declaring dependencies on net-url and lrexlib-pcre, and configuring module build mappings for jsonschema and jsonschema.store modules.

Changes

Cohort / File(s) Summary
LuaRocks Package Specification
rockspec/jsonschema-0.9.12-0.rockspec
Added rockspec file specifying package source tag, dependencies (net-url and lrexlib-pcre 2.9.1-1), and builtin build configuration mapping two Lua modules to their respective source files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • feat: release v0.9.10 #97: Adds similar LuaRocks rockspec for jsonschema with identical module mappings and dependencies, differing only by version tag.
  • feat: release v0.9.11 #99: Adds rockspec for jsonschema v0.9.11 with same structure and modules, directly preceding this v0.9.12 release specification.

Suggested reviewers

  • nic-6443
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
E2e Test Quality Review ❓ Inconclusive PR adds a .rockspec package metadata file, which is configuration for LuaRocks distribution rather than testable source code changes requiring E2E test validation. Clarify whether this is purely a release/packaging PR (requiring release checklist review) or if testable code changes exist elsewhere that need E2E validation.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: releasing version 0.9.12 of the jsonschema package via a new rockspec file.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed Pull request adds only a LuaRocks package specification file with public metadata, dependencies, and module mappings. No API keys, tokens, credentials, passwords, or sensitive data are exposed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nic/release-v0.9.12

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the LuaRocks rockspec needed to publish/release jsonschema version 0.9.12 from tag v0.9.12.

Changes:

  • Introduce rockspec/jsonschema-0.9.12-0.rockspec with updated version and source.tag.
  • Keep dependencies and module mappings consistent with prior recent releases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
rockspec/jsonschema-0.9.12-0.rockspec (1)

21-24: Use the pessimistic operator ~> to relax the lrexlib-pcre pin while maintaining compatibility.

The exact pin 2.9.1-1 limits compatibility unnecessarily. LuaRocks recommends the pessimistic operator ~> (e.g., "lrexlib-pcre ~> 2.9.1") to allow patch updates within the minor version (>= 2.9.1, < 2.10.0) while preserving reasonable reproducibility. Use dependency locks in CI for full reproducibility when needed.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@rockspec/jsonschema-0.9.12-0.rockspec` around lines 21 - 24, Replace the
strict pin "lrexlib-pcre = 2.9.1-1" in the dependencies table with a pessimistic
operator style requirement (e.g., "lrexlib-pcre ~> 2.9.1") so the dependency
entry in the dependencies block allows patch updates within the 2.9.x series
while preserving compatibility.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@rockspec/jsonschema-0.9.12-0.rockspec`:
- Around line 21-24: Replace the strict pin "lrexlib-pcre = 2.9.1-1" in the
dependencies table with a pessimistic operator style requirement (e.g.,
"lrexlib-pcre ~> 2.9.1") so the dependency entry in the dependencies block
allows patch updates within the 2.9.x series while preserving compatibility.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df0a383e-f2ee-4dc3-adff-ad060bb8e3f3

📥 Commits

Reviewing files that changed from the base of the PR and between 92b1ea2 and 35379fd.

📒 Files selected for processing (1)
  • rockspec/jsonschema-0.9.12-0.rockspec

@nic-6443 nic-6443 merged commit 9d410a7 into master Apr 27, 2026
12 checks passed
@nic-6443 nic-6443 deleted the nic/release-v0.9.12 branch April 27, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants