ci: add tests#234
Conversation
|
|
||
| - name: Install Dependencies | ||
| run: | | ||
| npm ci --force |
There was a problem hiding this comment.
--force sounds scary, why is it needed here?
There was a problem hiding this comment.
it was like this in apify-sdk-js, i just assumed it was the way to go, I agree to remove it 👍
There was a problem hiding this comment.
We can probably scrap this whole file (it's empty atm)
| - name: Cancel Workflow Action | ||
| uses: styfle/cancel-workflow-action@0.13.0 | ||
| with: | ||
| access_token: ${{ github.token }} |
There was a problem hiding this comment.
Maybe we can replace this with a native concurrency clause? (docs)
There was a problem hiding this comment.
Oh so they are the same thing! The package also mention it but I left it in because maybe there was something I didn't know was doing 😅 I'll change it!
|
Tests are now working properly https://github.com/apify/actor-scraper/actions/runs/22178976928/job/64134992390 ✅ |
nikitachapovskii-dev
left a comment
nikitachapovskii-dev
left a comment
There was a problem hiding this comment.
Looks good to me.
| cache-dependency-path: 'package-lock.json' | ||
|
|
||
| - name: Install Dependencies | ||
| run: npm ci --force |
There was a problem hiding this comment.
Hey just a quick note: npm ci --force is still used in Lint. I think we should align it with build & test as @barjin noticed
barjin
left a comment
barjin
left a comment
There was a problem hiding this comment.
one last comment, otherwise lgtm 👍 thanks!
| "test:e2e": "npm run test:e2e:scrapers", | ||
| "test:e2e:scrapers": "node test/e2e/runScraperTests.mjs", |
There was a problem hiding this comment.
maybe we can drop the :scrapers script, as it's the same as e2e?
4 participants
Closes #218
There was an initial problem with some leftover from the transfer from
apify-sdk-jswith references toapify/src. I removed them and addedapifyas a dev dependency.Another problem was due to a misnomer of
actor-sitemap-scraperwhich is nowactor-sitemap-extractor. Not really sure what's going on there,npm itook care of everything 😅 This will enable the e2e testsI copied the workflow from
apify-sdk-js. I removed the parts that didn't make sense for me (like the multiple node version testings) but feel free to comment on them and educate me, I'm very new to GH actions.