Merged
Conversation
Replaces ESLint with oxlint, pulling in the shared `@apify/oxlint-config` preset and `oxlint-tsgolint` for type-aware rules. Mirrors the migration already shipped in apify-storage-local-js, apify-shared-js, apify-core, apify-client-js, and apify-sdk-js. Prettier remains in place — the oxfmt swap is the next PR. - Drop `eslint`, `typescript-eslint`, `eslint-config-prettier`, `@apify/eslint-config` - Add `oxlint@1.62.0`, `oxlint-tsgolint@0.22.0`, `@apify/oxlint-config@^0.2.5` - Replace `eslint.config.mjs` with `oxlint.config.ts`; drop unused `tsconfig.eslint.json` / `tsconfig.eslint.website.json` - `lint` / `lint:fix` and lint-staged now run `oxlint --type-aware` - Drop deprecated `baseUrl` from tsconfigs and switch the inline `paths` entries to relative form so oxlint-tsgolint can parse them - Add `noEmit: true` to `test/tsconfig.json` so tsgolint doesn't try to overwrite the e2e `.mjs` fixtures - Switch two `.ts` extension imports in `scraper-tools` to `.js` for consistency with the rest of the package - Ignore the actor packages (`packages/actor-scraper/*`) in oxlint — they're application code with their own bundler-specific tsconfigs; the shared `scraper-tools` library is still linted - One source fix: drop unused `err` in `web-scraper` catch block - One disable comment for an intentional generic param used only by a declaration-merged interface in `scraper-tools/src/context.ts`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces ESLint with oxlint, pulling in the shared
@apify/oxlint-configpreset andoxlint-tsgolintfor type-aware rules. Mirrors the migration already shipped in apify-storage-local-js, apify-shared-js, apify-core, apify-client-js, and apify-sdk-js. Prettier remains in place — the oxfmt swap is the next PR.What changed
eslint,typescript-eslint,eslint-config-prettier,@apify/eslint-configoxlint@1.62.0,oxlint-tsgolint@0.22.0,@apify/oxlint-config@^0.2.5eslint.config.mjswithoxlint.config.ts; drop unusedtsconfig.eslint.json/tsconfig.eslint.website.jsonlint/lint:fixand lint-staged now runoxlint --type-awarebaseUrlfrom tsconfigs and switch the inlinepathsentries to relative form so oxlint-tsgolint can parse themnoEmit: truetotest/tsconfig.jsonso tsgolint doesn't try to overwrite the e2e.mjsfixtures.tsextension imports inscraper-toolsto.jsfor consistency with the rest of the packagepackages/actor-scraper/*) in oxlint — they're application code with their own bundler-specific tsconfigs; the sharedscraper-toolslibrary is still lintederrinweb-scrapercatch blockscraper-tools/src/context.tsLint output
```
$ pnpm lint
Found 1 warning and 0 errors.
Finished in 143ms on 40 files with 117 rules using 14 threads.
```
(The single warning — `no-unsafe-optional-chaining` in scraper-tools — is pre-existing.)
Test plan