-
Notifications
You must be signed in to change notification settings - Fork 47
Expand file tree
/
Copy pathpush.test.ts
More file actions
416 lines (332 loc) · 13.6 KB
/
push.test.ts
File metadata and controls
416 lines (332 loc) · 13.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
import { existsSync, readFileSync, unlinkSync, writeFileSync } from 'node:fs';
import { mkdir, writeFile } from 'node:fs/promises';
import type { ActorCollectionCreateOptions } from 'apify-client';
import { ACTOR_SOURCE_TYPES, SOURCE_FILE_FORMATS, STORAGE_GENERAL_ACCESS } from '@apify/consts';
import { createHmacSignature } from '@apify/utilities';
import { testRunCommand } from '../../../src/lib/command-framework/apify-command.js';
import { LOCAL_CONFIG_PATH } from '../../../src/lib/consts.js';
import { execWithLog } from '../../../src/lib/exec.js';
import { createSourceFiles, getActorLocalFilePaths, getLocalUserInfo } from '../../../src/lib/utils.js';
import { testUserClient } from '../../__setup__/config.js';
import { TEST_TIMEOUT } from '../../__setup__/consts.js';
import { safeLogin, useAuthSetup } from '../../__setup__/hooks/useAuthSetup.js';
import { useConsoleSpy } from '../../__setup__/hooks/useConsoleSpy.js';
import { useTempPath } from '../../__setup__/hooks/useTempPath.js';
import { useUniqueId } from '../../__setup__/hooks/useUniqueId.js';
import { resetCwdCaches } from '../../__setup__/reset-cwd-caches.js';
const ACTOR_NAME = useUniqueId('cli-push');
const TEST_ACTOR: ActorCollectionCreateOptions = {
name: ACTOR_NAME,
isPublic: false,
versions: [
{
versionNumber: '0.0',
sourceType: 'SOURCE_FILES' as never,
buildTag: 'latest',
sourceFiles: [],
},
],
};
const ACT_TEMPLATE = 'project_empty';
useAuthSetup({ perTest: false });
const {
beforeAllCalls,
afterAllCalls,
joinPath,
tmpPath,
toggleCwdBetweenFullAndParentPath,
joinCwdPath,
forceNewCwd,
} = useTempPath(ACTOR_NAME, { create: true, remove: true, cwd: true, cwdParent: true });
const { lastErrorMessage } = useConsoleSpy();
const { CreateCommand } = await import('../../../src/commands/create.js');
const { ActorsPushCommand } = await import('../../../src/commands/actors/push.js');
describe('[api] apify push', () => {
const actorsForCleanup = new Set<string>();
beforeAll(async () => {
await beforeAllCalls();
await safeLogin();
await testRunCommand(CreateCommand, {
args_actorName: ACTOR_NAME,
flags_template: ACT_TEMPLATE,
flags_skipDependencyInstall: true,
});
toggleCwdBetweenFullAndParentPath();
}, TEST_TIMEOUT);
afterAll(async () => {
await afterAllCalls();
for (const actorId of actorsForCleanup) {
const actorClient = testUserClient.actor(actorId);
await actorClient.delete();
}
});
beforeEach(() => {
resetCwdCaches();
});
it(
'should work without actorId',
async () => {
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
actorJson.environmentVariables = {
MY_ENV_VAR: 'envVarValue',
};
writeFileSync(joinPath(LOCAL_CONFIG_PATH), JSON.stringify(actorJson, null, '\t'), { flag: 'w' });
await testRunCommand(ActorsPushCommand, { flags_force: true });
const userInfo = await getLocalUserInfo();
const { name } = actorJson;
const actorId = `${userInfo.username}/${name}`;
actorsForCleanup.add(actorId);
const createdActorClient = testUserClient.actor(actorId);
const createdActor = await createdActorClient.get();
const createdActorVersion = await createdActorClient.version(actorJson.version).get();
const filePathsToPush = await getActorLocalFilePaths(tmpPath);
const sourceFiles = await createSourceFiles(filePathsToPush, tmpPath);
if (createdActor) await createdActorClient.delete();
expect(createdActorVersion!.versionNumber).to.be.eql(actorJson.version);
expect(createdActorVersion!.buildTag).to.be.eql('latest');
expect(createdActorVersion!.envVars).to.be.eql([
{
name: 'MY_ENV_VAR',
value: 'envVarValue',
},
]);
// TODO: vlad, fix this too
expect((createdActorVersion as any)!.sourceFiles.sort()).to.be.eql(sourceFiles.sort());
expect(createdActorVersion!.sourceType).to.be.eql(ACTOR_SOURCE_TYPES.SOURCE_FILES);
},
TEST_TIMEOUT,
);
it(
'should work with actorId',
async () => {
let testActor = await testUserClient.actors().create(TEST_ACTOR);
const testActorClient = testUserClient.actor(testActor.id);
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
await testRunCommand(ActorsPushCommand, {
args_actorId: testActor.id,
flags_force: true,
});
actorsForCleanup.add(testActor.id);
testActor = (await testActorClient.get())!;
const testActorVersion = await testActorClient.version(actorJson!.version).get();
const filePathsToPush = await getActorLocalFilePaths(tmpPath);
const sourceFiles = await createSourceFiles(filePathsToPush, tmpPath);
if (testActor) await testActorClient.delete();
expect(testActorVersion!.versionNumber).to.be.eql(actorJson.version);
expect(testActorVersion!.buildTag).to.be.eql('latest');
expect(testActorVersion!.envVars).to.be.eql([
{
name: 'MY_ENV_VAR',
value: 'envVarValue',
},
]);
expect((testActorVersion as any).sourceFiles.sort()).to.be.eql(sourceFiles.sort());
expect(testActorVersion!.sourceType).to.be.eql(ACTOR_SOURCE_TYPES.SOURCE_FILES);
},
TEST_TIMEOUT,
);
it(
'should not rewrite current Actor envVars',
async () => {
const testActorWithEnvVars = { ...TEST_ACTOR };
testActorWithEnvVars.versions = [
{
versionNumber: '0.0',
sourceType: 'SOURCE_FILES' as never,
buildTag: 'latest',
sourceFiles: [],
envVars: [
{
name: 'MY_TEST',
value: 'myValue',
},
],
},
];
let testActor = await testUserClient.actors().create(testActorWithEnvVars);
actorsForCleanup.add(testActor.id);
const testActorClient = testUserClient.actor(testActor.id);
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
delete actorJson.environmentVariables;
writeFileSync(joinPath(LOCAL_CONFIG_PATH), JSON.stringify(actorJson, null, '\t'), { flag: 'w' });
await testRunCommand(ActorsPushCommand, { args_actorId: testActor.id });
testActor = (await testActorClient.get())!;
const testActorVersion = await testActorClient.version(actorJson.version).get();
const filePathsToPush = await getActorLocalFilePaths(tmpPath);
const sourceFiles = await createSourceFiles(filePathsToPush, tmpPath);
if (testActor) await testActorClient.delete();
expect(testActorVersion!.versionNumber).to.be.eql(actorJson.version);
expect(testActorVersion!.envVars).to.be.eql(testActorWithEnvVars.versions[0].envVars);
expect((testActorVersion as any).sourceFiles.sort()).to.be.eql(sourceFiles.sort());
expect(testActorVersion!.sourceType).to.be.eql(ACTOR_SOURCE_TYPES.SOURCE_FILES);
},
TEST_TIMEOUT,
);
it(
'should upload zip for source files larger that 3MB',
async () => {
const testActorWithEnvVars = { ...TEST_ACTOR };
testActorWithEnvVars.versions = [
{
versionNumber: '0.0',
sourceType: 'TARBALL' as any,
buildTag: 'latest',
tarballUrl: 'http://example.com/my_test.zip',
envVars: [
{
name: 'MY_TEST',
value: 'myValue',
},
],
},
];
let testActor = await testUserClient.actors().create(testActorWithEnvVars);
actorsForCleanup.add(testActor.id);
const testActorClient = testUserClient.actor(testActor.id);
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
delete actorJson.environmentVariables;
writeFileSync(joinPath(LOCAL_CONFIG_PATH), JSON.stringify(actorJson, null, '\t'), { flag: 'w' });
// Create large file to ensure Actor will be uploaded as zip
writeFileSync(joinPath('3mb-file.txt'), Buffer.alloc(1024 * 1024 * 3));
await testRunCommand(ActorsPushCommand, { args_actorId: testActor.id });
// Remove the big file so sources in following tests are not zipped
unlinkSync(joinPath('3mb-file.txt'));
testActor = (await testActorClient.get())!;
const testActorVersion = await testActorClient.version(actorJson.version).get();
const store = await testUserClient.keyValueStores().getOrCreate(`actor-${testActor.id}-source`);
// Update the store's general access to RESTRICTED
await testUserClient.keyValueStore(store.id).update({ generalAccess: STORAGE_GENERAL_ACCESS.RESTRICTED });
expect(store.urlSigningSecretKey).toBeDefined();
const signature = createHmacSignature(store.urlSigningSecretKey!, `version-${actorJson.version}.zip`);
// Check if the tarball URL is accessible
await expect(fetch((testActorVersion as { tarballUrl: string }).tarballUrl)).resolves.toHaveProperty(
'status',
200,
);
await testUserClient.keyValueStore(store.id).delete();
if (testActor) await testActorClient.delete();
expect(testActorVersion).to.be.eql({
versionNumber: actorJson.version,
buildTag: 'latest',
tarballUrl:
`${testActorClient.baseUrl}/key-value-stores/${store.id}` +
`/records/version-${actorJson.version}.zip?disableRedirect=true&signature=${signature}`,
envVars: testActorWithEnvVars.versions[0].envVars,
sourceType: ACTOR_SOURCE_TYPES.TARBALL,
});
},
TEST_TIMEOUT,
);
it(
'typescript files should be treated as text',
async () => {
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
const { name, version } = actorJson;
writeFileSync(joinPath('some-typescript-file.ts'), `console.log('ok');`);
await testRunCommand(ActorsPushCommand, { flags_force: true });
if (existsSync(joinPath('some-typescript-file.ts'))) unlinkSync(joinPath('some-typescript-file.ts'));
const userInfo = await getLocalUserInfo();
const actorId = `${userInfo.username}/${name}`;
actorsForCleanup.add(actorId);
const createdActorClient = testUserClient.actor(actorId);
const createdActor = await createdActorClient.get();
const createdActorVersion = await createdActorClient.version(version).get();
if (createdActor) await createdActorClient.delete();
expect(
(createdActorVersion as any).sourceFiles.find((file: any) => file.name === 'some-typescript-file.ts')
.format,
).to.be.equal(SOURCE_FILE_FORMATS.TEXT);
},
TEST_TIMEOUT,
);
it(
'should not push Actor when there is newer version on platform',
async () => {
const testActor = await testUserClient.actors().create(TEST_ACTOR);
actorsForCleanup.add(testActor.id);
const testActorClient = testUserClient.actor(testActor.id);
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
// @ts-expect-error Wrong typing of update method
await testActorClient.version(actorJson.version).update({ buildTag: 'beta' });
await testRunCommand(ActorsPushCommand, { args_actorId: testActor.id });
if (testActor) await testActorClient.delete();
expect(lastErrorMessage()).to.includes('is already on the platform');
},
TEST_TIMEOUT,
);
it(
'should set title and description when creating a new actor',
async () => {
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
actorJson.name = `${actorJson.name}-title-test`;
actorJson.title = 'My Custom Actor Title';
actorJson.description = 'This is a custom description for the actor.';
writeFileSync(joinPath(LOCAL_CONFIG_PATH), JSON.stringify(actorJson, null, '\t'), { flag: 'w' });
await testRunCommand(ActorsPushCommand, { flags_force: true });
const userInfo = await getLocalUserInfo();
const actorId = `${userInfo.username}/${actorJson.name}`;
actorsForCleanup.add(actorId);
const createdActorClient = testUserClient.actor(actorId);
const createdActor = await createdActorClient.get();
expect(createdActor?.title).to.be.eql('My Custom Actor Title');
expect(createdActor?.description).to.be.eql('This is a custom description for the actor.');
if (createdActor) await createdActorClient.delete();
},
TEST_TIMEOUT,
);
it(
'should not rewrite current Actor title and description',
async () => {
const testActorWithTitleDesc = {
...TEST_ACTOR,
title: 'Original Title',
description: 'Original description.',
};
let testActor = await testUserClient.actors().create(testActorWithTitleDesc);
actorsForCleanup.add(testActor.id);
const testActorClient = testUserClient.actor(testActor.id);
// Remove title and description from local actor.json
const actorJson = JSON.parse(readFileSync(joinPath(LOCAL_CONFIG_PATH), 'utf8'));
delete actorJson.title;
delete actorJson.description;
writeFileSync(joinPath(LOCAL_CONFIG_PATH), JSON.stringify(actorJson, null, '\t'), { flag: 'w' });
await testRunCommand(ActorsPushCommand, { args_actorId: testActor.id });
testActor = (await testActorClient.get())!;
if (testActor) await testActorClient.delete();
// Title and description should be preserved from the original actor
expect(testActor.title).to.be.eql('Original Title');
expect(testActor.description).to.be.eql('Original description.');
},
TEST_TIMEOUT,
);
it(
'should not push Actor when there are no files to push',
async () => {
toggleCwdBetweenFullAndParentPath();
await mkdir(joinCwdPath('empty-dir'), { recursive: true });
forceNewCwd('empty-dir');
await testRunCommand(ActorsPushCommand, {});
expect(lastErrorMessage()).to.include(
'You need to call this command from a folder that has an Actor in it',
);
},
TEST_TIMEOUT,
);
it(
'should not push when the folder does not seem to have a valid Actor',
async () => {
toggleCwdBetweenFullAndParentPath();
await mkdir(joinCwdPath('not-an-actor-i-promise'), { recursive: true });
forceNewCwd('not-an-actor-i-promise');
await writeFile(joinCwdPath('owo.txt'), 'Lorem ipsum');
await execWithLog({
cmd: 'git',
args: ['init'],
opts: { cwd: joinCwdPath() },
});
await testRunCommand(ActorsPushCommand, {});
expect(lastErrorMessage()).to.include('A valid Actor could not be found in the current directory.');
},
TEST_TIMEOUT,
);
});