fix: Set correct exit code on incorect apify secrets usage (#1021)

- closes #953

Author: janbuchar

src/lib/command-framework/apify-command.ts

@@ -299,6 +299,7 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 		}
 
 		if (missingRequiredArgs.size) {
+			process.exitCode = 1;
 			this._printMissingRequiredArgs(missingRequiredArgs);
 			return;
 		}
@@ -309,6 +310,7 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 			await this.run();
 		} catch (err: any) {
 			error({ message: err.message });
+			process.exitCode ||= 1;
 		} finally {
 			// analytics
 			if (!this.telemetryData.actorLanguage && COMMANDS_WITHIN_ACTOR.includes(this.commandString)) {
@@ -588,9 +590,15 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 	}
 
 	private _printMissingRequiredArgs(missingRequiredArgs: Map<string, TaggedArgBuilder<ArgTag, unknown>>) {
-		const help = selectiveRenderHelpForCommand(this.ctor, {
-			showUsageString: true,
-		});
+		let help: string | undefined;
+
+		try {
+			help = selectiveRenderHelpForCommand(this.ctor, {
+				showUsageString: true,
+			});
+		} catch {
+			// Help renderer may not be registered (e.g. in tests)
+		}
 
 		const widestArgNameLength = widestLine([...missingRequiredArgs.keys()].join('\n'));
 
@@ -606,14 +614,18 @@ export abstract class ApifyCommand<T extends typeof BuiltApifyCommand = typeof B
 			missingArgsStrings.push(`  ${chalk.red('>')}  ${indented}`);
 		}
 
+		const messageParts = [
+			`Missing ${missingRequiredArgs.size} required ${this.pluralString(missingRequiredArgs.size, 'argument', 'arguments')}:`,
+			...missingArgsStrings,
+			chalk.gray('  See more help with --help'),
+		];
+
+		if (help) {
+			messageParts.push('', help);
+		}
+
 		error({
-			message: [
-				`Missing ${missingRequiredArgs.size} required ${this.pluralString(missingRequiredArgs.size, 'argument', 'arguments')}:`,
-				...missingArgsStrings,
-				chalk.gray('  See more help with --help'),
-				'',
-				help,
-			].join('\n'),
+			message: messageParts.join('\n'),
 		});
 	}
 

test/local/commands/secrets/add.test.ts

@@ -16,6 +16,10 @@ describe('apify secrets add', () => {
 		}
 	});
 
+	afterEach(() => {
+		process.exitCode = undefined;
+	});
+
 	it('should work', async () => {
 		await testRunCommand(SecretsAddCommand, {
 			args_name: SECRET_KEY,
@@ -26,6 +30,23 @@ describe('apify secrets add', () => {
 		expect(secrets[SECRET_KEY]).to.eql(SECRET_VALUE);
 	});
 
+	it('should exit with non-zero code when adding a duplicate secret', async () => {
+		// The first add should succeed (added in the "should work" test above)
+		await testRunCommand(SecretsAddCommand, {
+			args_name: SECRET_KEY,
+			args_value: SECRET_VALUE,
+		});
+
+		expect(process.exitCode).to.eql(1);
+	});
+
+	it('should exit with non-zero code when called without arguments', async () => {
+		// @ts-expect-error -- We intentionally pass no args to test the missing args case
+		await testRunCommand(SecretsAddCommand, {});
+
+		expect(process.exitCode).to.eql(1);
+	});
+
 	afterAll(async () => {
 		const secrets = getSecretsFile();