extract parsing function and add regression tests

Author: l2ysho

src/commands/actors/push.ts

@@ -25,6 +25,7 @@ import {
 	getLocalUserInfo,
 	getLoggedClientOrThrow,
 	outputJobLog,
+	parseWaitForFinishMillis,
 	printJsonToStdout,
 } from '../../lib/utils.js';
 
@@ -190,8 +191,7 @@ export class ActorsPushCommand extends ApifyCommand<typeof ActorsPushCommand> {
 			buildTag = DEFAULT_BUILD_TAG;
 		}
 
-		const parsedWaitForFinish = this.flags.waitForFinish ? Number.parseInt(this.flags.waitForFinish, 10) : Number.NaN;
-		const waitForFinishMillis = Number.isFinite(parsedWaitForFinish) ? parsedWaitForFinish * 1000 : undefined;
+		const waitForFinishMillis = parseWaitForFinishMillis(this.flags.waitForFinish);
 
 		// User can override actorId of pushing Actor.
 		// It causes that we push Actor to this id but attributes in localConfig will remain same.

src/lib/utils.ts

@@ -840,3 +840,10 @@ export function shellConfigFile(userHomeDirectory: string, shell: ReturnType<typ
 		}
 	}
 }
+
+export function parseWaitForFinishMillis(flag: string | undefined): number | undefined {
+	if (flag === undefined) return undefined;
+	const parsed = Number.parseInt(flag, 10);
+	if (!Number.isFinite(parsed) || parsed <= 0) return undefined;
+	return parsed * 1000;
+}

test/local/lib/parse-wait-for-finish.test.ts

@@ -0,0 +1,23 @@
+import { parseWaitForFinishMillis } from '../../../src/lib/utils.js';
+
+describe('parseWaitForFinishMillis()', () => {
+	it('returns undefined when flag is omitted', () => {
+		expect(parseWaitForFinishMillis(undefined)).toBeUndefined();
+	});
+
+	it('returns undefined for non-numeric input', () => {
+		expect(parseWaitForFinishMillis('abc')).toBeUndefined();
+	});
+
+	it('returns undefined for zero', () => {
+		expect(parseWaitForFinishMillis('0')).toBeUndefined();
+	});
+
+	it('returns undefined for negative values', () => {
+		expect(parseWaitForFinishMillis('-5')).toBeUndefined();
+	});
+
+	it('converts positive seconds to milliseconds', () => {
+		expect(parseWaitForFinishMillis('30')).toBe(30_000);
+	});
+});