Swap globby with tinyglobby

[l2ysho]

Globby is relatively heavy and, for our use case, doesn’t offer much more than tinyglobby, which is smaller and does the same job.

[vladfrangu]

When moving off of globby we also want to make sure we still respect .gitignores!

[l2ysho]

When moving off of globby we also want to make sure we still respect .gitignores!

tinyglobby do not care about gitignore, but they provide workaround in migration guide

Problem is it depends on git's ls-files and I am not sure what are the consequence of this, because now we can throw error on push if git ls-files is not available.

As I see it we have 2 options

• accept git is a requirement for CLI :/
• process gitignore files on our own (check how globby doing it? ), but it is another place to make an error so we have to cover it with tests
• use globby (for now)

@vladfrangu @B4nan

[B4nan]

If there is a .gitignore and git is available, I would go with the workaround via ls-files. If git is not available, it sounds allright to me to not respect .gitignore. We shouldn't fail because of this (I would maybe print a warning like "git is not available but .gitignore file is present, to respect it during apify push, make sure git is available" (of course, in better english 😭).

[vladfrangu]

I don't think git should be a requirement at all for us to respect .gitignore, I can imagine someone whos not very well versed in programming to create an actor without having git installed and then when they push, node_modules just comes with...

[l2ysho]

What about https://www.npmjs.com/package/ignore?

[vladfrangu]

We can use that + manual collection of all .gitignores I suppose? (since we need to find a git root, and then scan for all .gitignore files from the root down)

[l2ysho]

checking the bundle size after beta is build, v1.2.2-beta32 -> globby vs v1.2.2-beta33 -> tinygloby + ignore and actually it is worse by 0.01MB with tinygloby + ignore 😠 cc @vladfrangu @B4nan

[vladfrangu]

Probably just because theres more code now, its fine

[B4nan]

More code, but less dependencies, I would expect lower bundle size for sure (I mean the single executable bundles at least). But whatever, we got rid of some transitive dependencies, that's also a good outcome on its own.