Skip to content

ci: rebase before pushing release/pre-release commits#1109

Merged
B4nan merged 1 commit intomasterfrom
ci/release-rebase-on-push
Apr 29, 2026
Merged

ci: rebase before pushing release/pre-release commits#1109
B4nan merged 1 commit intomasterfrom
ci/release-rebase-on-push

Conversation

@B4nan
Copy link
Copy Markdown
Member

@B4nan B4nan commented Apr 29, 2026

Summary

Add pull: '--rebase --autostash' to the EndBug/add-and-commit step in the update_changelog jobs of both release.yaml and pre_release.yaml, so the changelog/version commits survive a concurrent ref update on master.

Context

Same race that bit apify/apify-client-js in run 25114327598:

remote rejected (cannot lock ref 'refs/heads/master': is at <new> but expected <old>)

The bypass logs remote: Bypassed rule violations for refs/heads/master — so it's not permissions, it's just non-fast-forward because something landed on master between checkout and push. pre_release.yaml is especially exposed since it's triggered on every push to master.

🤖 Generated with Claude Code

@B4nan B4nan requested a review from vladfrangu as a code owner April 29, 2026 14:55
@github-actions github-actions Bot added this to the 139th sprint - Tooling team milestone Apr 29, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 29, 2026
Why: Both release.yaml and pre_release.yaml push the changelog/version
bump to master via EndBug/add-and-commit. If anything else lands on
master between checkout and push, the push is rejected with `cannot
lock ref` — non-fast-forward, even when the service-account bypass
succeeds. Adding `pull: '--rebase --autostash'` lets EndBug rebase
onto the new tip first.
@B4nan B4nan force-pushed the ci/release-rebase-on-push branch from a31f42d to 102a743 Compare April 29, 2026 15:05
@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 29, 2026
@B4nan B4nan requested a review from barjin April 29, 2026 15:13
@B4nan B4nan merged commit 66abc66 into master Apr 29, 2026
43 of 45 checks passed
@B4nan B4nan deleted the ci/release-rebase-on-push branch April 29, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants