ci: add --allow-same-version to pnpm version calls in release workflows#1116
Merged
ci: add --allow-same-version to pnpm version calls in release workflows#1116
Conversation
B4nan
approved these changes
May 4, 2026
Member
B4nan
left a comment
There was a problem hiding this comment.
interesting, but why wasnt the version bumped in the first place?
Member
Author
|
I think its because we commit the bump the first time it happens and then it gets cached?.... Actually I am confused too, lemme check |
Member
Author
|
Yep, that seems to be what it is, pre-release flow bumped it when we merged the PR to change the default output path for generate-schema-types, and now it stays like that until we release |
Member
|
still not enough i guess https://github.com/apify/apify-cli/actions/runs/25337371938/job/74285892074 |
Member
Author
|
I hate git checks on pnpm so MUCH. Did you guys not have issues with that in crawlee? |
Member
Author
|
Looked at storage local js, and there is |
Member
|
Crawlee doesn't use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allow-same-versionflag topnpm versioncalls inrelease.yamlandpre_release.yamlworkflowsTesting