Skip to content

ci: add --allow-same-version to pnpm version calls in release workflows#1116

Merged
B4nan merged 1 commit intomasterfrom
ci/fix-pnpm-same-version
May 4, 2026
Merged

ci: add --allow-same-version to pnpm version calls in release workflows#1116
B4nan merged 1 commit intomasterfrom
ci/fix-pnpm-same-version

Conversation

@vladfrangu
Copy link
Copy Markdown
Member

Summary

  • Adds --allow-same-version flag to pnpm version calls in release.yaml and pre_release.yaml workflows
  • Prevents release failures when pnpm tries to set a version that is already set (e.g. on re-runs or when the version hasn't changed)
  • No functional change to the release process itself

Testing

  • Not run — CI-only change; correctness is verified by the release workflows passing on next trigger

@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 4, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 4, 2026
@vladfrangu vladfrangu requested a review from B4nan May 4, 2026 18:14
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label May 4, 2026
Copy link
Copy Markdown
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, but why wasnt the version bumped in the first place?

@vladfrangu
Copy link
Copy Markdown
Member Author

I think its because we commit the bump the first time it happens and then it gets cached?.... Actually I am confused too, lemme check

@vladfrangu
Copy link
Copy Markdown
Member Author

Yep, that seems to be what it is, pre-release flow bumped it when we merged the PR to change the default output path for generate-schema-types, and now it stays like that until we release

@B4nan B4nan merged commit d169be1 into master May 4, 2026
23 of 24 checks passed
@B4nan B4nan deleted the ci/fix-pnpm-same-version branch May 4, 2026 18:47
@B4nan
Copy link
Copy Markdown
Member

B4nan commented May 4, 2026

@vladfrangu
Copy link
Copy Markdown
Member Author

I hate git checks on pnpm so MUCH. Did you guys not have issues with that in crawlee?

@vladfrangu
Copy link
Copy Markdown
Member Author

Looked at storage local js, and there is --no-git-checks

@B4nan
Copy link
Copy Markdown
Member

B4nan commented May 4, 2026

Crawlee doesn't use npm version, we have a custom implementation for the bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants