Skip to content

Commit 1b03bbc

Browse files
vdusekclaude
andcommitted
fix: Restore timeout parameter on _update() method
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4829e3a commit 1b03bbc

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

src/apify_client/_resource_clients/_resource_client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,13 +206,14 @@ def _get(self, *, timeout: timedelta | None = None) -> dict | None:
206206
catch_not_found_or_throw(exc)
207207
return None
208208

209-
def _update(self, **kwargs: Any) -> dict:
209+
def _update(self, *, timeout: timedelta | None = None, **kwargs: Any) -> dict:
210210
"""Perform a PUT request to update this resource with the given fields."""
211211
response = self._http_client.call(
212212
url=self._build_url(),
213213
method='PUT',
214214
params=self._build_params(),
215215
json=self._clean_json_payload(kwargs),
216+
timeout=timeout,
216217
)
217218
return response_to_dict(response)
218219

@@ -372,13 +373,14 @@ async def _get(self, *, timeout: timedelta | None = None) -> dict | None:
372373
catch_not_found_or_throw(exc)
373374
return None
374375

375-
async def _update(self, **kwargs: Any) -> dict:
376+
async def _update(self, *, timeout: timedelta | None = None, **kwargs: Any) -> dict:
376377
"""Perform a PUT request to update this resource with the given fields."""
377378
response = await self._http_client.call(
378379
url=self._build_url(),
379380
method='PUT',
380381
params=self._build_params(),
381382
json=self._clean_json_payload(kwargs),
383+
timeout=timeout,
382384
)
383385
return response_to_dict(response)
384386

src/apify_client/_resource_clients/dataset.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def update(self, *, name: str | None = None, general_access: GeneralAccess | Non
9494
Returns:
9595
The updated dataset.
9696
"""
97-
result = self._update(name=name, generalAccess=general_access)
97+
result = self._update(timeout=FAST_OPERATION_TIMEOUT, name=name, generalAccess=general_access)
9898
return DatasetResponse.model_validate(result).data
9999

100100
def delete(self) -> None:
@@ -709,7 +709,7 @@ async def update(self, *, name: str | None = None, general_access: GeneralAccess
709709
Returns:
710710
The updated dataset.
711711
"""
712-
result = await self._update(name=name, generalAccess=general_access)
712+
result = await self._update(timeout=FAST_OPERATION_TIMEOUT, name=name, generalAccess=general_access)
713713
return DatasetResponse.model_validate(result).data
714714

715715
async def delete(self) -> None:

src/apify_client/_resource_clients/key_value_store.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def update(self, *, name: str | None = None, general_access: GeneralAccess | Non
105105
Returns:
106106
The updated key-value store.
107107
"""
108-
result = self._update(name=name, generalAccess=general_access)
108+
result = self._update(timeout=FAST_OPERATION_TIMEOUT, name=name, generalAccess=general_access)
109109
return KeyValueStoreResponse.model_validate(result).data
110110

111111
def delete(self) -> None:
@@ -488,7 +488,7 @@ async def update(
488488
Returns:
489489
The updated key-value store.
490490
"""
491-
result = await self._update(name=name, generalAccess=general_access)
491+
result = await self._update(timeout=FAST_OPERATION_TIMEOUT, name=name, generalAccess=general_access)
492492
return KeyValueStoreResponse.model_validate(result).data
493493

494494
async def delete(self) -> None:

src/apify_client/_resource_clients/request_queue.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def update(self, *, name: str | None = None, general_access: GeneralAccess | Non
100100
Returns:
101101
The updated request queue.
102102
"""
103-
result = self._update(name=name, generalAccess=general_access)
103+
result = self._update(timeout=FAST_OPERATION_TIMEOUT, name=name, generalAccess=general_access)
104104
return RequestQueueResponse.model_validate(result).data
105105

106106
def delete(self) -> None:
@@ -509,7 +509,7 @@ async def update(
509509
Returns:
510510
The updated request queue.
511511
"""
512-
result = await self._update(name=name, generalAccess=general_access)
512+
result = await self._update(timeout=FAST_OPERATION_TIMEOUT, name=name, generalAccess=general_access)
513513
return RequestQueueResponse.model_validate(result).data
514514

515515
async def delete(self) -> None:

0 commit comments

Comments
 (0)