refactor: rename expires_in_seconds to expires_in_secs

Author: danpoletaev

src/apify_client/clients/resource_clients/dataset.py

@@ -579,14 +579,14 @@ def create_items_public_url(
         skip_hidden: bool | None = None,
         flatten: list[str] | None = None,
         view: str | None = None,
-        expires_in_seconds: int | None = None,
+        expires_in_secs: int | None = None,
     ) -> str:
         """Generate a URL that can be used to access dataset items.
 
         If the client has permission to access the dataset's URL signing key,
         the URL will include a signature to verify its authenticity.
 
-        You can optionally control how long the signed URL should be valid using the `expires_in_seconds` option.
+        You can optionally control how long the signed URL should be valid using the `expires_in_secs` option.
         This value sets the expiration duration in seconds from the time the URL is generated.
         If not provided, the URL will not expire.
 
@@ -615,7 +615,7 @@ def create_items_public_url(
             signature = create_storage_content_signature(
                 resource_id=dataset['id'],
                 url_signing_secret_key=dataset['urlSigningSecretKey'],
-                expires_in_millis=expires_in_seconds * 1000 if expires_in_seconds is not None else None,
+                expires_in_millis=expires_in_secs * 1000 if expires_in_secs is not None else None,
             )
             request_params['signature'] = signature
 
@@ -1086,14 +1086,14 @@ async def create_items_public_url(
         skip_hidden: bool | None = None,
         flatten: list[str] | None = None,
         view: str | None = None,
-        expires_in_seconds: int | None = None,
+        expires_in_secs: int | None = None,
     ) -> str:
         """Generate a URL that can be used to access dataset items.
 
         If the client has permission to access the dataset's URL signing key,
         the URL will include a signature to verify its authenticity.
 
-        You can optionally control how long the signed URL should be valid using the `expires_in_seconds` option.
+        You can optionally control how long the signed URL should be valid using the `expires_in_secs` option.
         This value sets the expiration duration in seconds from the time the URL is generated.
         If not provided, the URL will not expire.
 
@@ -1122,7 +1122,7 @@ async def create_items_public_url(
             signature = create_storage_content_signature(
                 resource_id=dataset['id'],
                 url_signing_secret_key=dataset['urlSigningSecretKey'],
-                expires_in_millis=expires_in_seconds * 1000 if expires_in_seconds is not None else None,
+                expires_in_millis=expires_in_secs * 1000 if expires_in_secs is not None else None,
             )
             request_params['signature'] = signature
 

src/apify_client/clients/resource_clients/key_value_store.py

@@ -274,14 +274,14 @@ def create_keys_public_url(
         exclusive_start_key: str | None = None,
         collection: str | None = None,
         prefix: str | None = None,
-        expires_in_seconds: int | None = None,
+        expires_in_secs: int | None = None,
     ) -> str:
         """Generate a URL that can be used to access key-value store keys.
 
         If the client has permission to access the key-value store's URL signing key,
         the URL will include a signature to verify its authenticity.
 
-        You can optionally control how long the signed URL should be valid using the `expires_in_seconds` option.
+        You can optionally control how long the signed URL should be valid using the `expires_in_secs` option.
         This value sets the expiration duration in seconds from the time the URL is generated.
         If not provided, the URL will not expire.
 
@@ -303,7 +303,7 @@ def create_keys_public_url(
             signature = create_storage_content_signature(
                 resource_id=store['id'],
                 url_signing_secret_key=store['urlSigningSecretKey'],
-                expires_in_millis=expires_in_seconds * 1000 if expires_in_seconds is not None else None,
+                expires_in_millis=expires_in_secs * 1000 if expires_in_secs is not None else None,
             )
             request_params['signature'] = signature
 
@@ -562,14 +562,14 @@ async def create_keys_public_url(
         exclusive_start_key: str | None = None,
         collection: str | None = None,
         prefix: str | None = None,
-        expires_in_seconds: int | None = None,
+        expires_in_secs: int | None = None,
     ) -> str:
         """Generate a URL that can be used to access key-value store keys.
 
         If the client has permission to access the key-value store's URL signing key,
         the URL will include a signature to verify its authenticity.
 
-        You can optionally control how long the signed URL should be valid using the `expires_in_seconds` option.
+        You can optionally control how long the signed URL should be valid using the `expires_in_secs` option.
         This value sets the expiration duration in seconds from the time the URL is generated.
         If not provided, the URL will not expire.
 
@@ -593,7 +593,7 @@ async def create_keys_public_url(
             signature = create_storage_content_signature(
                 resource_id=store['id'],
                 url_signing_secret_key=store['urlSigningSecretKey'],
-                expires_in_millis=expires_in_seconds * 1000 if expires_in_seconds is not None else None,
+                expires_in_millis=expires_in_secs * 1000 if expires_in_secs is not None else None,
             )
             request_params['signature'] = signature
 

tests/integration/test_dataset.py

@@ -16,7 +16,7 @@ def test_dataset_should_create_public_items_expiring_url_with_params(self, apify
 
         dataset = apify_client.dataset(created_dataset['id'])
         items_public_url = dataset.create_items_public_url(
-            expires_in_seconds=2000,
+            expires_in_secs=2000,
             limit=10,
             offset=0,
         )
@@ -56,7 +56,7 @@ async def test_dataset_should_create_public_items_expiring_url_with_params(
 
         dataset = apify_client_async.dataset(created_dataset['id'])
         items_public_url = await dataset.create_items_public_url(
-            expires_in_seconds=2000,
+            expires_in_secs=2000,
             limit=10,
             offset=0,
         )

tests/integration/test_key_value_store.py

@@ -18,7 +18,7 @@ def test_key_value_store_should_create_expiring_keys_public_url_with_params(
 
         store = apify_client.key_value_store(created_store['id'])
         keys_public_url = store.create_keys_public_url(
-            expires_in_seconds=2000,
+            expires_in_secs=2000,
             limit=10,
         )
 
@@ -58,7 +58,7 @@ async def test_key_value_store_should_create_expiring_keys_public_url_with_param
 
         store = apify_client_async.key_value_store(created_store['id'])
         keys_public_url = await store.create_keys_public_url(
-            expires_in_seconds=2000,
+            expires_in_secs=2000,
             limit=10,
         )